Re: [PATCH] scsi: timeout reset timer before command is queued

[Matthew Wilcox <matthew@wil.cx>]

On Mon, Dec 14, 2009 at 06:40:13PM -0800, Min Zhang wrote:
> +    /*
> +     * Extend timeout if cmd has not been queued yet, otherwise error
> +     * handler could complete request and free the cmd memory while
> +     * the dispatch handler still uses the cmd pointer.
> +     */
> +    if (scmd->eh_eflags | SCSI_EH_RESET_TIMER)
> +        return BLK_EH_RESET_TIMER;

Oh, and what on earth is this?  The condition will always be true.  I
think you meant '&', not '|'.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."