From: Pete Zaitcev <zaitcev@redhat.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Colin McCabe <cmccabe@alumni.cmu.edu>,
Project Hail List <hail-devel@vger.kernel.org>
Subject: Re: [PATCH 0/6 v2] logging refactoring
Date: Tue, 15 Dec 2009 15:47:33 -0700 [thread overview]
Message-ID: <20091215154733.39cfb54f@redhat.com> (raw)
In-Reply-To: <4B280FDA.9010705@garzik.org>
On Tue, 15 Dec 2009 17:38:18 -0500
Jeff Garzik <jeff@garzik.org> wrote:
> > In fact, does anyone even understand why we continue to split
> > LOG_WARNING and LOG_ERR? We really have three log levels:
> > - debug
> > - info (which is actually an error)
> > - error (not really all that different from info actually)
> > Might as well create HAIL_DEBUG, HAIL_INFO, and HAIL_ERR (to be
> > used before exit(1), with values of 0,1,2 and remap to syslog
> > values where it goes to syslog.
>
> It would be nice to disconnect from syslog, yes. But the 'warning' log
> level has value.
Can you offer any guidelines that are easy to follow and enforce?
I am often confused and select the level randomly. The only rule
I follow is: if and only if it's under if (debugging), then LOG_DEBUG.
Otherwise... hmm...
-- Pete
next prev parent reply other threads:[~2009-12-15 22:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 0:11 [PATCH 0/6 v2] logging refactoring Colin McCabe
2009-12-09 0:11 ` [PATCH 1/6] cld: Declare common.c functions in common.h Colin McCabe
2009-12-09 0:11 ` [PATCH 2/6] cld: create logging macros Colin McCabe
2009-12-09 0:11 ` [PATCH 3/6] cld: modify client code to use " Colin McCabe
2009-12-09 0:11 ` [PATCH 4/6] cld: modify server " Colin McCabe
2009-12-09 0:11 ` [PATCH 5/6] cld: modify cld-dns " Colin McCabe
2009-12-09 20:35 ` Pete Zaitcev
2009-12-10 0:44 ` Colin McCabe
2009-12-09 0:11 ` [PATCH 6/6] cld: Tweak some log levels in cldc dns Colin McCabe
2009-12-14 7:23 ` [PATCH 0/6 v2] logging refactoring Colin McCabe
2009-12-14 20:36 ` Jeff Garzik
2009-12-15 2:18 ` Colin McCabe
2009-12-15 18:19 ` Pete Zaitcev
2009-12-15 22:38 ` Jeff Garzik
2009-12-15 22:47 ` Pete Zaitcev [this message]
2009-12-15 22:57 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091215154733.39cfb54f@redhat.com \
--to=zaitcev@redhat.com \
--cc=cmccabe@alumni.cmu.edu \
--cc=hail-devel@vger.kernel.org \
--cc=jeff@garzik.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.