From: Borislav Petkov <borislav.petkov@amd.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andreas Herrmann <herrmann.der.user@googlemail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH resend] x86, amd: Get multi-node CPU info from NodeId MSR instead of PCI config space
Date: Tue, 15 Dec 2009 20:45:36 +0100 [thread overview]
Message-ID: <20091215194536.GC10747@aftab> (raw)
In-Reply-To: <20091215193150.GE15443@elte.hu>
On Tue, Dec 15, 2009 at 08:31:50PM +0100, Ingo Molnar wrote:
>
> * Andreas Herrmann <herrmann.der.user@googlemail.com> wrote:
>
> > + rdmsrl(0xc001100c, value);
>
> Dont we want some nice, meaningfully named symbolic constant here, instead of
> 0xc001100c?
The MSR name is actually in the commit msg, maybe something like
MSR_F10H_NODE_ID.
--
Regards/Gruss,
Boris.
Operating | Advanced Micro Devices GmbH
System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
Research | Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
(OSRC) | Registergericht München, HRB Nr. 43632
next prev parent reply other threads:[~2009-12-15 19:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 12:44 [PATCH resend] x86, amd: Get multi-node CPU info from NodeId MSR instead of PCI config space Andreas Herrmann
2009-12-15 19:31 ` Ingo Molnar
2009-12-15 19:45 ` Borislav Petkov [this message]
2009-12-16 14:43 ` [PATCH v2] " Andreas Herrmann
2009-12-17 1:00 ` [tip:x86/urgent] " tip-bot for Andreas Herrmann
-- strict thread matches above, loose matches on Subject: below --
2009-12-15 20:00 [PATCH resend] " H. Peter Anvin
2009-12-15 20:46 ` Borislav Petkov
2009-12-15 19:51 H. Peter Anvin
2009-10-16 12:22 Andreas Herrmann
2009-10-27 9:33 ` [PATCH RESEND] " Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091215194536.GC10747@aftab \
--to=borislav.petkov@amd.com \
--cc=herrmann.der.user@googlemail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.