All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pete Zaitcev <zaitcev@redhat.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: [Patch 1/3] tabled: drop commented messages
Date: Tue, 15 Dec 2009 22:09:33 -0700	[thread overview]
Message-ID: <20091215220933.4628e727@redhat.com> (raw)

Less clutter is good.

Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>

---
 server/cldu.c      |    3 ---
 server/storage.c   |   16 ----------------
 server/storparse.c |    1 -
 3 files changed, 20 deletions(-)

Jeff, if you recall, I promised to do this as a condition for a past merge.

commit a0c650bf82f22cd302fdb5e8a91537bb17f47d69
Author: Master <zaitcev@lembas.zaitcev.lan>
Date:   Tue Dec 15 21:12:57 2009 -0700

    Drop commented messages.

diff --git a/server/cldu.c b/server/cldu.c
index 467f6c2..609ed56 100644
--- a/server/cldu.c
+++ b/server/cldu.c
@@ -635,9 +635,6 @@ static int cldu_open_x_cb(struct cldc_call_opts *carg, enum cle_err_codes errc)
 		return 0;
 	}
 
-	// if (debugging)
-	// 	applog(LOG_DEBUG, "CLD directory \"%s\" opened", sp->xfname);
-
 	/*
 	 * Read the directory.
 	 */
diff --git a/server/storage.c b/server/storage.c
index b8f74e4..cc7066f 100644
--- a/server/storage.c
+++ b/server/storage.c
@@ -423,22 +423,6 @@ static int stor_add_node_addr(struct storage_node *sn,
 		sn->addr_af = res->ai_family;
 		sn->alen = res->ai_addrlen;
 
-#if 0
-		if (debugging) {
-			char nhost[41];
-			char nport[6];
-			if (getnameinfo((struct sockaddr *) &sn->addr, sn->alen,
-					nhost, sizeof(nhost),
-				        nport, sizeof(nport),
-					NI_NUMERICHOST|NI_NUMERICSERV) == 0) {
-				applog(LOG_INFO, "Found Chunk host %s port %s",
-				       nhost, nport);
-			} else {
-				applog(LOG_INFO, "Found Chunk host");
-			}
-		}
-#endif
-
 		/* Use just the first address for now. */
 		freeaddrinfo(res0);
 		return 0;
diff --git a/server/storparse.c b/server/storparse.c
index 25841d2..35548bf 100644
--- a/server/storparse.c
+++ b/server/storparse.c
@@ -145,7 +145,6 @@ static void cfg_elm_end_geo(struct config_context *cc)
 	}
 
 	if (!cc->loc.rack) {
-		// applog(LOG_WARNING, "%s: No rack in Geo element", cc->fname);
 		goto end;
 	}
 

                 reply	other threads:[~2009-12-16  5:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091215220933.4628e727@redhat.com \
    --to=zaitcev@redhat.com \
    --cc=hail-devel@vger.kernel.org \
    --cc=jeff@garzik.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.