All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-tip-commits@vger.kernel.org, linux-kernel@vger.kernel.org,
	hpa@zytor.com, mingo@redhat.com, peterz@infradead.org,
	tglx@linutronix.de
Subject: Re: [tip:sched/urgent] sched: Teach might_sleep() about preemptible RCU
Date: Wed, 16 Dec 2009 19:57:32 +0100	[thread overview]
Message-ID: <20091216185723.GA5211@nowhere> (raw)
In-Reply-To: <20091216153020.GD6744@linux.vnet.ibm.com>

On Wed, Dec 16, 2009 at 07:30:20AM -0800, Paul E. McKenney wrote:
> On Wed, Dec 16, 2009 at 03:25:36PM +0100, Ingo Molnar wrote:
> > 
> > * tip-bot for Frederic Weisbecker <fweisbec@gmail.com> wrote:
> > 
> > > Commit-ID:  ba1b1cbcc9b458c4b9ebb28c9cf6a2ccf64ba1cd
> > > Gitweb:     http://git.kernel.org/tip/ba1b1cbcc9b458c4b9ebb28c9cf6a2ccf64ba1cd
> > > Author:     Frederic Weisbecker <fweisbec@gmail.com>
> > > AuthorDate: Mon, 14 Dec 2009 23:44:32 +0100
> > > Committer:  Ingo Molnar <mingo@elte.hu>
> > > CommitDate: Wed, 16 Dec 2009 08:43:16 +0100
> > > 
> > > sched: Teach might_sleep() about preemptible RCU
> > 
> > Causes a build failure, so skipped this patch for now:
> > 
> > kernel/sched.c:9661: error: implicit declaration of function 'rcu_preempt_depth'
> 
> I guess my testing missed something.  :-/  Could you please send the
> .config file that caused this?
> 
> 							Thanx, Paul


Looks like the problem is here:

rcupdate.h:

	#if defined(CONFIG_TREE_RCU) || defined(CONFIG_TREE_PREEMPT_RCU)
	#include <linux/rcutree.h>
	#elif defined(CONFIG_TINY_RCU)
	#include <linux/rcutiny.h>

I guess it barfs in rcutiny configs.

I should define these helpers in rcupdate.


  reply	other threads:[~2009-12-16 18:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-14 22:44 [PATCH] sched: Teach might_sleep about preemptable rcu Frederic Weisbecker
2009-12-14 23:03 ` Paul E. McKenney
2009-12-16  8:18 ` [tip:sched/urgent] sched: Teach might_sleep() about preemptible RCU tip-bot for Frederic Weisbecker
2009-12-16 14:25   ` Ingo Molnar
2009-12-16 15:30     ` Paul E. McKenney
2009-12-16 18:57       ` Frederic Weisbecker [this message]
2009-12-16 19:13         ` Frederic Weisbecker
2009-12-16 19:21     ` [PATCH] " Frederic Weisbecker
2009-12-16 19:23       ` Frederic Weisbecker
2009-12-17  1:37         ` Paul E. McKenney
2009-12-17  8:49           ` Ingo Molnar
2009-12-17 19:49             ` Paul E. McKenney
2009-12-17 10:52       ` [tip:sched/urgent] " tip-bot for Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091216185723.GA5211@nowhere \
    --to=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.