From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Chiang Subject: Re: [PATCH] Drop 80-character limit in checkpatch.pl Date: Wed, 16 Dec 2009 12:59:35 -0700 Message-ID: <20091216195935.GA551@ldl.fc.hp.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Mikulas Patocka Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Alasdair G Kergon , dm-devel@redhat.com List-Id: dm-devel.ids I've no comments on the actual patch but... * Mikulas Patocka : > Drop 80-character limit in checkpatch.pl > > Serious issues: > =============== > > (1) The code is hard to edit with common text editors You mention vi; most distros provide vim these days. In my .vimrc, I have: set ai set si That helps a bit. > (2) Grepping the code is unreliable Reviewers (at least in my part of the kernel) have been requesting that user-visible (and thus developer greppable) output be combined on one line precisely for this reason. We've been rejecting patches that unnecessarily break up these strings at 80 cols. > But some maintainers take output of the script checkpatch.pl > dogmatically, requiring that every new work must pass the > script without a warning. This is the real problem. And I think the solution is to lobby your maintainer. fwiw, /ac