All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: devtmpfs [censored] oddities
Date: Wed, 16 Dec 2009 17:00:41 -0800	[thread overview]
Message-ID: <20091217010041.GA6479@suse.de> (raw)
In-Reply-To: <20091217004643.GR14381@ZenIV.linux.org.uk>

On Thu, Dec 17, 2009 at 12:46:43AM +0000, Al Viro wrote:
> On Wed, Dec 16, 2009 at 04:39:22PM -0800, Greg KH wrote:
> > On Wed, Dec 16, 2009 at 08:04:31AM +0000, Al Viro wrote:
> > > 	May I respectfully suggest that a blocking operation (such as
> > > kstrdup with GFP_KERNEL, or grabbing a mutex, or, say it, pathname resolution)
> > > is not quite the thing to do while holding an rwlock?
> > > 
> > > 	As it is, any device_add() is an embarrassingly obvious deadlock
> > > waiting to happen...
> > 
> > Thomas has posted a patch to fix this now.
> > 
> > Sorry for not catching it sooner, we should just delete the rwlocks so
> > no one tries to ever use it again.
> 
> Say again?  Why would we delete rwlocks?

Sorry, no _new_ use of rwlocks should be added, generally they are used
incorrectly, like this one was.

thanks,

greg k-h

      reply	other threads:[~2009-12-17  1:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-16  8:04 devtmpfs [censored] oddities Al Viro
2009-12-17  0:39 ` Greg KH
2009-12-17  0:46   ` Al Viro
2009-12-17  1:00     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091217010041.GA6479@suse.de \
    --to=gregkh@suse.de \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.