From: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
H Peter Anvin <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org, Mike Travis <travis@sgi.com>
Subject: [PATCH] x86: trivial - reenable Skipped synchronization message once at boot
Date: Wed, 16 Dec 2009 17:43:48 -0800 [thread overview]
Message-ID: <20091217014348.GA684@linux-os.sc.intel.com> (raw)
commit 9b3660a5 changed below
- printk_once(KERN_INFO "Skipping synchronization checks
as TSC is
+ if (cpu == (nr_cpu_ids-1) || system_state !=
SYSTEM_BOOTING)
+ pr_info(
+ "Skipped synchronization checks as TSC is
reliable.\n");
which results in "Skipped synchronization checks as TSC is reliable"
message missing from my dmesg. The problem is that nr_cpu_ids is number
of possible CPUs, and courtesy extra disabled cpus in my bios, that
number is higher than real cpus.
Change the check to num_present_cpus() - 1, which gets us back to old
behavior of printing this message once at boot.
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
---
arch/x86/kernel/tsc_sync.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/tsc_sync.c b/arch/x86/kernel/tsc_sync.c
index 0aa5fed..6fe5184 100644
--- a/arch/x86/kernel/tsc_sync.c
+++ b/arch/x86/kernel/tsc_sync.c
@@ -114,9 +114,11 @@ void __cpuinit check_tsc_sync_source(int cpu)
return;
if (boot_cpu_has(X86_FEATURE_TSC_RELIABLE)) {
- if (cpu == (nr_cpu_ids-1) || system_state != SYSTEM_BOOTING)
+ if (cpu == (num_present_cpus() - 1) ||
+ system_state != SYSTEM_BOOTING) {
pr_info(
"Skipped synchronization checks as TSC is reliable.\n");
+ }
return;
}
--
1.6.0.6
reply other threads:[~2009-12-17 1:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091217014348.GA684@linux-os.sc.intel.com \
--to=venkatesh.pallipadi@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.