From: Pavel Vasilyev <pavel@pavlinux.ru>
To: linux-kernel@vger.kernel.org
Subject: HTC Dream camera, not need sizeof
Date: Thu, 17 Dec 2009 05:13:45 +0300 [thread overview]
Message-ID: <200912170513.45388@PAVLINUX-> (raw)
http://bugzilla.kernel.org/show_bug.cgi?id=14825
On line 258, sizeof(extlen), always will be sizeof( unit32_t) or 4
It seems that something is wrong?!?! :)
Original
255 extlen = sizeof(struct vfe_frame_extra);
256
257 extdata =
258 kmalloc(sizeof(extlen), GFP_ATOMIC);
is equal kmalloc(sizeof(uint32_t), GFP_ATOMIC);
But then do not need to calculate the size of the structure -
sizeof(vfe_frame_extra) ???
259 if (!extdata) {
260 rc = -ENOMEM;
261 goto init_fail;
---------------------
May be next?
diff --git a/drivers/staging/dream/camera/msm_vfe7x.c
b/drivers/staging/dream/camera/msm_vfe7x.c
index 33ab3ac..4d39848 100644
--- a/drivers/staging/dream/camera/msm_vfe7x.c
+++ b/drivers/staging/dream/camera/msm_vfe7x.c
@@ -256,7 +256,7 @@ static int vfe_7x_init(struct msm_vfe_callback *presp,
extlen = sizeof(struct vfe_frame_extra);
extdata =
- kmalloc(sizeof(extlen), GFP_ATOMIC);
+ kmalloc(extlen, GFP_ATOMIC);
if (!extdata) {
rc = -ENOMEM;
goto init_fail;
reply other threads:[~2009-12-17 2:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912170513.45388@PAVLINUX- \
--to=pavel@pavlinux.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.