From: Paul Moore <paul.moore@hp.com>
To: James Morris <jmorris@namei.org>
Cc: selinux@tycho.nsa.gov, Russell Coker <russell@coker.com.au>,
amworsley@gmail.com
Subject: Re: [RFC PATCH v2] selinux: Fix security_compute_av() to not return unknown class errors when in permissive mode
Date: Thu, 17 Dec 2009 18:28:33 -0500 [thread overview]
Message-ID: <200912171828.33410.paul.moore@hp.com> (raw)
In-Reply-To: <alpine.LRH.2.00.0912171845380.2193@tundra.namei.org>
On Thursday 17 December 2009 02:59:29 am James Morris wrote:
> On Wed, 16 Dec 2009, Paul Moore wrote:
> > It is possible security_compute_av() to return -EINVAL, even when in
> > permissive mode, due to unknown object classes and SIDs. This patch
> > fixes this by doing away with the return value for security_compute_av()
> > and treating unknown classes and SIDs as permission denials.
> >
> > NOTE: I've only tested this on Fedora/Rawhide using the standard policy,
> > so while I'm fairly confident there are no regressions in the common case
> > the error case hasn't been fully tested yet; I'm posting this to solicit
> > comments on the basic approach.
>
> Looks ok to me.
Me too. I tested today with a hacked Fedora/Rawhide policy that didn't have
the tun_socket class; it worked as expected both when set to allow and deny
unknown classes. As far as I'm concerned you can feel free to merge this
patch when appropriate.
Andrew, I'll make sure this applies cleanly to 2.6.32 tomorrow, if not I'll
send you a backported patch.
--
paul moore
linux @ hp
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2009-12-17 23:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 22:10 [RFC PATCH v2] selinux: Fix security_compute_av() to not return unknown class errors when in permissive mode Paul Moore
2009-12-17 7:59 ` James Morris
2009-12-17 23:28 ` Paul Moore [this message]
2009-12-18 0:48 ` Stephen Smalley
2009-12-18 18:23 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912171828.33410.paul.moore@hp.com \
--to=paul.moore@hp.com \
--cc=amworsley@gmail.com \
--cc=jmorris@namei.org \
--cc=russell@coker.com.au \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.