From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave McCracken <dcm@mccr.org>
Subject: Re: [PATCH] linux/balloon: prefer using pages from
	balloon in alloc_empty_pages_and_pagevec()
Date: Fri, 18 Dec 2009 08:32:54 -0600
Message-ID: <200912180832.54632.dcm@mccr.org>
References: <4B2907320200007800026472@vpn.id2.novell.com>
	<200912171433.04459.dcm@mccr.org>
	<4B2B42DD020000780002694A@vpn.id2.novell.com>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4B2B42DD020000780002694A@vpn.id2.novell.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <JBeulich@novell.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Friday 18 December 2009, Jan Beulich wrote:
> >>> Dave McCracken <dcm@mccr.org> 17.12.09 21:33 >>>
> >
> >I don't see anything wrong with the error path.  It correctly walks back
> > down  the pagevec and frees all the pages it's allocated so far.
> 
> Oh, you're probably looking at the code past the err: label, but I was
> referring to the handling of a failed apply_to_page_range().

Ok, yeah.  It frees up the page that's currently being worked on, then jumps 
to err: to clean up all the other pages in the pagevec and free the pagevec.  
Is there something wrong about it that I'm missing?

Dave McCracken
Oracle Corp