From mboxrd@z Thu Jan 1 00:00:00 1970 From: "jack_wang" Date: Sat, 19 Dec 2009 14:08:03 +0000 Subject: Re: [PATCH 5/7] drivers/scsi/pm8001: Use kzalloc for allocating onlyone thing Message-Id: <200912192208027036843@usish.com> List-Id: References: MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1254" Content-Transfer-Encoding: base64 To: Julia Lawall , lindar_liu , "James E.J. Bottomley" , linux-scsi linux-kernel UkWjultQQVRDSCA1LzddIGRyaXZlcnMvc2NzaS9wbTgwMDE6IFVzZSBremFsbG9jIGZvciBhbGxv Y2F0aW5nIG9ubHlvbmUgdGhpbmcKCkZyb206IEp1bGlhIExhd2FsbCA8anVsaWFAZGlrdS5kaz4K ClVzZSBremFsbG9jIHJhdGhlciB0aGFuIGtjYWxsb2MoMSwuLi4pCgpUaGUgc2VtYW50aWMgcGF0 Y2ggdGhhdCBtYWtlcyB0aGlzIGNoYW5nZSBpcyBhcyBmb2xsb3dzOgooaHR0cDovL2NvY2NpbmVs bGUubGlwNi5mci8pCgovLyA8c21wbD4KQEAKQEAKCi0ga2NhbGxvYygxLAorIGt6YWxsb2MoCiAg ICAgICAgICAuLi4pCi8vIDwvc21wbD4KClNpZ25lZC1vZmYtYnk6IEp1bGlhIExhd2FsbCA8anVs aWFAZGlrdS5kaz4KCi0tLQogZHJpdmVycy9zY3NpL3BtODAwMS9wbTgwMDFfaW5pdC5jIHwgICAg MiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZm IC11IC1wIGEvZHJpdmVycy9zY3NpL3BtODAwMS9wbTgwMDFfaW5pdC5jIGIvZHJpdmVycy9zY3Np L3BtODAwMS9wbTgwMDFfaW5pdC5jCi0tLSBhL2RyaXZlcnMvc2NzaS9wbTgwMDEvcG04MDAxX2lu aXQuYyAyMDA5LTEyLTEyIDAwOjIzOjE5LjAwMDAwMDAwMCArMDEwMAorKysgYi9kcml2ZXJzL3Nj c2kvcG04MDAxL3BtODAwMV9pbml0LmMgMjAwOS0xMi0xOSAwNzo1Mjo0NC4wMDAwMDAwMDAgKzAx MDAKQEAgLTY1NCw3ICs2NTQsNyBAQCBzdGF0aWMgaW50IF9fZGV2aW5pdCBwbTgwMDFfcGNpX3By b2JlKHN0CiAJfQogCWNoaXAgPSAmcG04MDAxX2NoaXBzW2VudC0+ZHJpdmVyX2RhdGFdOwogCVNI T1NUX1RPX1NBU19IQShzaG9zdCkgLQkJa2NhbGxvYygxLCBzaXplb2Yoc3RydWN0IHNhc19oYV9z dHJ1Y3QpLCBHRlBfS0VSTkVMKTsKKwkJa3phbGxvYyhzaXplb2Yoc3RydWN0IHNhc19oYV9zdHJ1 Y3QpLCBHRlBfS0VSTkVMKTsKIAlpZiAoIVNIT1NUX1RPX1NBU19IQShzaG9zdCkpIHsKIAkJcmMg PSAtRU5PTUVNOwogCQlnb3RvIGVycl9vdXRfZnJlZV9ob3N0OwoKCltKYWNrXUFja2VkLWJ5Okph Y2sgV2FuZyA8amFja193YW5nQHVzaXNoLmNvbT4KVGhhbmtzLCBKdWxpYQr/9Oi6ey5uxyuJt5+u ia2GKyWKy/+x6d22F6WKd/+6ey5uxyuJt6R6ud6X+NqeK2iuz+Ke2F5uh3Kh9qZ6yxqB62iZqOit 2iaj++B6v+R6ud6X+iuAyit6ZqOit2iaiKd+hq2G22n//++B6v+R6ud6X+iuD+ZqOit2iaj+Kd+j +G0K From mboxrd@z Thu Jan 1 00:00:00 1970 From: "jack_wang" Subject: Re: [PATCH 5/7] drivers/scsi/pm8001: Use kzalloc for allocating onlyone thing Date: Sat, 19 Dec 2009 22:08:03 +0800 Message-ID: <200912192208027036843@usish.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 Return-path: Received: from sr-smtp.usish.com ([210.5.144.203]:51859 "EHLO sr-smtp.usish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750772AbZLSOHC (ORCPT ); Sat, 19 Dec 2009 09:07:02 -0500 Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Julia Lawall , lindar_liu , "James E.J. Bottomley" , linux-scsi linux-kernel UkWjultQQVRDSCA1LzddIGRyaXZlcnMvc2NzaS9wbTgwMDE6IFVzZSBremFsbG9jIGZvciBhbGxv Y2F0aW5nIG9ubHlvbmUgdGhpbmcNCg0KRnJvbTogSnVsaWEgTGF3YWxsIDxqdWxpYUBkaWt1LmRr Pg0KDQpVc2Uga3phbGxvYyByYXRoZXIgdGhhbiBrY2FsbG9jKDEsLi4uKQ0KDQpUaGUgc2VtYW50 aWMgcGF0Y2ggdGhhdCBtYWtlcyB0aGlzIGNoYW5nZSBpcyBhcyBmb2xsb3dzOg0KKGh0dHA6Ly9j b2NjaW5lbGxlLmxpcDYuZnIvKQ0KDQovLyA8c21wbD4NCkBADQpAQA0KDQotIGtjYWxsb2MoMSwN Cisga3phbGxvYygNCiAgICAgICAgICAuLi4pDQovLyA8L3NtcGw+DQoNClNpZ25lZC1vZmYtYnk6 IEp1bGlhIExhd2FsbCA8anVsaWFAZGlrdS5kaz4NCg0KLS0tDQogZHJpdmVycy9zY3NpL3BtODAw MS9wbTgwMDFfaW5pdC5jIHwgICAgMiArLQ0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr KSwgMSBkZWxldGlvbigtKQ0KDQpkaWZmIC11IC1wIGEvZHJpdmVycy9zY3NpL3BtODAwMS9wbTgw MDFfaW5pdC5jIGIvZHJpdmVycy9zY3NpL3BtODAwMS9wbTgwMDFfaW5pdC5jDQotLS0gYS9kcml2 ZXJzL3Njc2kvcG04MDAxL3BtODAwMV9pbml0LmMgMjAwOS0xMi0xMiAwMDoyMzoxOS4wMDAwMDAw MDAgKzAxMDANCisrKyBiL2RyaXZlcnMvc2NzaS9wbTgwMDEvcG04MDAxX2luaXQuYyAyMDA5LTEy LTE5IDA3OjUyOjQ0LjAwMDAwMDAwMCArMDEwMA0KQEAgLTY1NCw3ICs2NTQsNyBAQCBzdGF0aWMg aW50IF9fZGV2aW5pdCBwbTgwMDFfcGNpX3Byb2JlKHN0DQogCX0NCiAJY2hpcCA9ICZwbTgwMDFf Y2hpcHNbZW50LT5kcml2ZXJfZGF0YV07DQogCVNIT1NUX1RPX1NBU19IQShzaG9zdCkgPQ0KLQkJ a2NhbGxvYygxLCBzaXplb2Yoc3RydWN0IHNhc19oYV9zdHJ1Y3QpLCBHRlBfS0VSTkVMKTsNCisJ CWt6YWxsb2Moc2l6ZW9mKHN0cnVjdCBzYXNfaGFfc3RydWN0KSwgR0ZQX0tFUk5FTCk7DQogCWlm ICghU0hPU1RfVE9fU0FTX0hBKHNob3N0KSkgew0KIAkJcmMgPSAtRU5PTUVNOw0KIAkJZ290byBl cnJfb3V0X2ZyZWVfaG9zdDsNCg0KDQpbSmFja11BY2tlZC1ieTpKYWNrIFdhbmcgPGphY2tfd2Fu Z0B1c2lzaC5jb20+DQpUaGFua3MsIEp1bGlhDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752394AbZLSOTb (ORCPT ); Sat, 19 Dec 2009 09:19:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752148AbZLSOTa (ORCPT ); Sat, 19 Dec 2009 09:19:30 -0500 Received: from sr-smtp.usish.com ([210.5.144.203]:51887 "EHLO sr-smtp.usish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751822AbZLSOT3 (ORCPT ); Sat, 19 Dec 2009 09:19:29 -0500 X-Greylist: delayed 747 seconds by postgrey-1.27 at vger.kernel.org; Sat, 19 Dec 2009 09:19:28 EST Date: Sat, 19 Dec 2009 22:08:03 +0800 From: "jack_wang" To: "Julia Lawall" , "lindar_liu" , "James E.J. Bottomley" , "linux-scsi" , "linux-kernel" , "kernel-janitors" References: Subject: Re: [PATCH 5/7] drivers/scsi/pm8001: Use kzalloc for allocating onlyone thing Message-ID: <200912192208027036843@usish.com> X-mailer: Foxmail 6, 15, 201, 22 [cn] Mime-Version: 1.0 Content-Type: text/plain; charset="gb2312" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by alpha.home.local id nBJEKS16001080 RE[PATCH 5/7] drivers/scsi/pm8001: Use kzalloc for allocating onlyone thing From: Julia Lawall Use kzalloc rather than kcalloc(1,...) The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ @@ - kcalloc(1, + kzalloc( ...) // Signed-off-by: Julia Lawall --- drivers/scsi/pm8001/pm8001_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -u -p a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c --- a/drivers/scsi/pm8001/pm8001_init.c 2009-12-12 00:23:19.000000000 +0100 +++ b/drivers/scsi/pm8001/pm8001_init.c 2009-12-19 07:52:44.000000000 +0100 @@ -654,7 +654,7 @@ static int __devinit pm8001_pci_probe(st } chip = &pm8001_chips[ent->driver_data]; SHOST_TO_SAS_HA(shost) = - kcalloc(1, sizeof(struct sas_ha_struct), GFP_KERNEL); + kzalloc(sizeof(struct sas_ha_struct), GFP_KERNEL); if (!SHOST_TO_SAS_HA(shost)) { rc = -ENOMEM; goto err_out_free_host; [Jack]Acked-by:Jack Wang Thanks, Julia {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I