From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NM8Kk-00057C-R6
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 18:03:34 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NM8Kk-00056p-4G
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 18:03:34 -0500
Received: from [199.232.76.173] (port=59344 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NM8Kj-00056i-UU
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 18:03:34 -0500
Received: from hall.aurel32.net ([88.191.82.174]:45355)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1NM8Kj-0001Ij-DM
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 18:03:33 -0500
Date: Sun, 20 Dec 2009 00:03:31 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 0/3] mips setcond and movcond
Message-ID: <20091219230331.GV24729@hall.aurel32.net>
References: <cover.1261260692.git.rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <cover.1261260692.git.rth@twiddle.net>
Sender: Aurelien Jarno <aurelien@aurel32.net>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Sat, Dec 19, 2009 at 10:43:31PM +0000, Richard Henderson wrote:
> It has been compile tested, but nothing else.
> 
> I'm moderately surprised at the implementation of brcond.  It's
> missing the BLTZ, BLEZ, BGTZ, BGEZ branches.  It's could be 
> improved with the SLTI and SLTIU insns used here with setcond.

The MIPS TCG support is really new, and the goal was to make it working,
not to get it as optimized as possible. Anyway I doubt it will make a
big difference in speed.

> Indeed, I suspect that a good implementation of brcond would be
> to take care of the cases implementable directly by branches,
> and then call into setcond to take care of the rest.  I don't
> plan to do that.
> 
> 
> r~
> 
> 
> 
> Richard Henderson (3):
>   tcg: Add tcg_swap_cond.
>   tcg-mips: Implement setcond, setcond2.
>   tcg-mips: Implement movcond.
> 
>  tcg/mips/tcg-target.c |  296 ++++++++++++++++++++++++++++++++++++++++++++++++-
>  tcg/tcg.h             |    8 ++
>  2 files changed, 302 insertions(+), 2 deletions(-)
> 
> 
> 
> 

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net