From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NM8SK-0003iR-3Z
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 18:11:24 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NM8SJ-0003iF-Ib
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 18:11:23 -0500
Received: from [199.232.76.173] (port=59203 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NM8SJ-0003iC-FC
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 18:11:23 -0500
Received: from hall.aurel32.net ([88.191.82.174]:53754)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1NM8SJ-0001kb-45
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 18:11:23 -0500
Date: Sun, 20 Dec 2009 00:11:20 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 0/5] tcg conditional set, round 4
Message-ID: <20091219231120.GA32531@volta.aurel32.net>
References: <cover.1261248772.git.rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <cover.1261248772.git.rth@twiddle.net>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Sat, Dec 19, 2009 at 10:52:52AM -0800, Richard Henderson wrote:
> Changes from round 3:
> 
>  * Drop movcond for now.
>  * Only use movzbl and not xor in setcond.
> 
> 

Thanks for the update, it looks like ready, I only have cosmetic or
minor comments. See my comments in the individual patches

I think we should commit it now, but wait a bit until it is implemented
in all TCG targets to use this new ops. We can circulate patches in the
meanwhile.

> 
> 
> Richard Henderson (5):
>   tcg: Generic support for conditional set
>   tcg-x86_64: Implement setcond.
>   tcg-i386: Implement small forward branches.
>   tcg: Add tcg_invert_cond.
>   tcg-i386: Implement setcond.
> 
>  elf.h                   |    2 +
>  tcg/README              |   20 +++++-
>  tcg/i386/tcg-target.c   |  187 +++++++++++++++++++++++++++++++++++++----------
>  tcg/tcg-op.h            |   47 ++++++++++++
>  tcg/tcg-opc.h           |    3 +
>  tcg/tcg.c               |   21 ++++--
>  tcg/tcg.h               |    5 +
>  tcg/x86_64/tcg-target.c |   38 ++++++++-
>  8 files changed, 271 insertions(+), 52 deletions(-)
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net