From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH 1/7] Nested VMX patch 1 implements vmon and vmoff
Date: Sun, 20 Dec 2009 16:25:50 +0200
Message-ID: <20091220142550.GJ4490@redhat.com>
References: <1260470309-7166-1-git-send-email-oritw@il.ibm.com>
 <1260470309-7166-2-git-send-email-oritw@il.ibm.com>
 <20091220142018.GI4490@redhat.com>
 <4B2E336A.802@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: oritw@il.ibm.com, kvm@vger.kernel.org, benami@il.ibm.com,
	abelg@il.ibm.com, muli@il.ibm.com, aliguori@us.ibm.com,
	mdday@us.ibm.com
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:44728 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752761AbZLTOZy (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 20 Dec 2009 09:25:54 -0500
Content-Disposition: inline
In-Reply-To: <4B2E336A.802@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, Dec 20, 2009 at 04:23:38PM +0200, Avi Kivity wrote:
> On 12/20/2009 04:20 PM, Gleb Natapov wrote:
> >+
> >>+	if (create_l1_state(vcpu)) {
> >>+		printk(KERN_ERR "%s create_l1_state failed\n", __func__);
> >>+		kvm_queue_exception(vcpu, UD_VECTOR);
> >Should we send UD exception if there is internal error? May be doing
> >VMfailinvalid would be more appropriate? Also this function doesn't handle
> >all errors (address alignment, version checking, register operand).
> 
> 
> Host errors like -ENOMEM should propagate to the return code of ioctl().
> 
Yes, even better.

--
			Gleb.