All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pete Zaitcev <zaitcev@redhat.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: [Patch 1/1] Chunk: fix stored checksums
Date: Sun, 20 Dec 2009 19:45:01 -0700	[thread overview]
Message-ID: <20091220194501.4cd6ad6f@redhat.com> (raw)

Existing code writes checksums of something other than the object data.
Fix by summing the object data.

Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>

---
 server/object.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This seems too obvious... Where is the trap?

diff -urpN -X dontdiff chunkd-m/server/object.c chunkd-tip/server/object.c
--- chunkd-m/server/object.c	2009-12-20 19:06:24.156353635 -0700
+++ chunkd-tip/server/object.c	2009-12-20 19:05:57.130476765 -0700
@@ -195,7 +195,7 @@ bool cli_evt_data_in(struct client *cli,
 			return cli_err(cli, che_InternalError, false);
 		}
 
-		SHA1_Update(&cli->out_hash, cli->req_ptr, bytes);
+		SHA1_Update(&cli->out_hash, p, bytes);
 
 		cli->out_len -= bytes;
 		p += bytes;

             reply	other threads:[~2009-12-21  2:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-21  2:45 Pete Zaitcev [this message]
2009-12-21  5:57 ` [Patch 1/1] Chunk: fix stored checksums Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091220194501.4cd6ad6f@redhat.com \
    --to=zaitcev@redhat.com \
    --cc=hail-devel@vger.kernel.org \
    --cc=jeff@garzik.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.