From: Andi Kleen <andi@firstfloor.org>
To: akpm@osdl.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, kyle@redhat.com,
benh@kernel.crashing.org, mmarek@suse.cz
Subject: [PATCH] Move -fno-dwarf2-cfi-asm to powerpc only
Date: Mon, 21 Dec 2009 02:23:51 +0100 [thread overview]
Message-ID: <20091221012351.GA24720@basil.fritz.box> (raw)
Move -fno-dwarf2-cfi-asm to powerpc only
Better dwarf2 unwind information is a good thing, it allows better
debugging with kgdb and crash and helps systemtap.
commit 003086497f07f7f1e67c0c295e261740f822b377 disabled some CFI
information globally to work around a module loader bug on powerpc.
But this disables the better unwind tables for all architectures,
not just powerpc. Move the workaround to powerpc and also
add a suitable comment that's it really a workaround.
This improves dwarf2 unwind tables on x86 at least.
Cc: kyle@redhat.com
Cc: benh@kernel.crashing.org
Cc: mmarek@suse.cz
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
Makefile | 3 ---
arch/powerpc/Makefile | 5 +++++
2 files changed, 5 insertions(+), 3 deletions(-)
Index: linux-2.6.33-rc1-ak/Makefile
===================================================================
--- linux-2.6.33-rc1-ak.orig/Makefile
+++ linux-2.6.33-rc1-ak/Makefile
@@ -570,9 +570,6 @@ KBUILD_CFLAGS += $(call cc-option,-Wno-p
# disable invalid "can't wrap" optimizations for signed / pointers
KBUILD_CFLAGS += $(call cc-option,-fno-strict-overflow)
-# revert to pre-gcc-4.4 behaviour of .eh_frame
-KBUILD_CFLAGS += $(call cc-option,-fno-dwarf2-cfi-asm)
-
# conserve stack if available
KBUILD_CFLAGS += $(call cc-option,-fconserve-stack)
Index: linux-2.6.33-rc1-ak/arch/powerpc/Makefile
===================================================================
--- linux-2.6.33-rc1-ak.orig/arch/powerpc/Makefile
+++ linux-2.6.33-rc1-ak/arch/powerpc/Makefile
@@ -112,6 +112,11 @@ KBUILD_CFLAGS += $(call cc-option,-mspe=
# kernel considerably.
KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time)
+# FIXME: the module load should be taught about the additional relocs
+# generated by this.
+# revert to pre-gcc-4.4 behaviour of .eh_frame
+KBUILD_CFLAGS += $(call cc-option,-fno-dwarf2-cfi-asm)
+
# Never use string load/store instructions as they are
# often slow when they are implemented at all
KBUILD_CFLAGS += -mno-string
next reply other threads:[~2009-12-21 1:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 1:23 Andi Kleen [this message]
2009-12-21 4:39 ` [PATCH] Move -fno-dwarf2-cfi-asm to powerpc only Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091221012351.GA24720@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=kyle@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.