From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Mon, 21 Dec 2009 13:36:54 +0100 Subject: [Cluster-devel] [PATCHv2 00/12]posix_acl: Add the check items In-Reply-To: <4B2F6153.8010609@gmail.com> References: <4B2F6153.8010609@gmail.com> Message-ID: <20091221123654.GA9201@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit I like taking these checks into posix_acl_valid, but I think the patch submission needs a bit more work. All the patches are extremly whitespace mangled. And I don't think splitting them up makes a whole lot of sense, when we do API changes like this we usually fix up all callers. So please try to fix your mailer, merged them all into one, and maybe also chose a more descriptive subject line, e.g. Subject: take checks for NULL and error pointers into posix_acl_valid() And btw, at least the XFS change seems incorrect - previously we returned NULL acl pointer and this patch changes it to -EINVAL. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id nBLCbLYL039196 for ; Mon, 21 Dec 2009 06:37:21 -0600 Date: Mon, 21 Dec 2009 13:36:54 +0100 From: Christoph Hellwig Subject: Re: [PATCHv2 00/12]posix_acl: Add the check items Message-ID: <20091221123654.GA9201@lst.de> References: <4B2F6153.8010609@gmail.com> Mime-Version: 1.0 Content-Disposition: inline In-Reply-To: <4B2F6153.8010609@gmail.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Liuwenyi Cc: adilger@sun.com, jack@suse.cz, neilb@suse.de, jeffm@suse.com, joel.becker@oracle.com, bfields@fieldses.org, linux-mtd@lists.infradead.org, onlyflyer@gmail.com, hch@lst.de, tiger.yang@oracle.com, strongzgy@gmail.com, ffilzlnx@us.ibm.com, sandeen@sandeen.net, jmorris@namei.org, cluster-devel@redhat.com, aelder@sgi.com, cjb@laptop.org, mfasheh@suse.com, bharrosh@panasas.com, reiserfs-devel@vger.kernel.org, xfs@oss.sgi.com, xfs-masters@oss.sgi.com, viro@zeniv.linux.org.uk, swhiteho@redhat.com, chris.mason@oracle.com, linux-nfs@vger.kernel.org, linux-ext4@vger.kernel.org, tytso@mit.edu, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, serue@us.ibm.com, dwmw2@infradead.org, ocfs2-devel@oss.oracle.com I like taking these checks into posix_acl_valid, but I think the patch submission needs a bit more work. All the patches are extremly whitespace mangled. And I don't think splitting them up makes a whole lot of sense, when we do API changes like this we usually fix up all callers. So please try to fix your mailer, merged them all into one, and maybe also chose a more descriptive subject line, e.g. Subject: take checks for NULL and error pointers into posix_acl_valid() And btw, at least the XFS change seems incorrect - previously we returned NULL acl pointer and this patch changes it to -EINVAL. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753339AbZLUMhh (ORCPT ); Mon, 21 Dec 2009 07:37:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753271AbZLUMhd (ORCPT ); Mon, 21 Dec 2009 07:37:33 -0500 Received: from verein.lst.de ([213.95.11.210]:47643 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756730AbZLUMha (ORCPT ); Mon, 21 Dec 2009 07:37:30 -0500 Date: Mon, 21 Dec 2009 13:37:27 +0100 From: Christoph Hellwig To: Liuwenyi Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 00/12]posix_acl: Add the check items Message-ID: <20091221123654.GA9201@lst.de> References: <4B2F6153.8010609@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B2F6153.8010609@gmail.com> User-Agent: Mutt/1.3.28i X-Spam-Score: 0 () Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I like taking these checks into posix_acl_valid, but I think the patch submission needs a bit more work. All the patches are extremly whitespace mangled. And I don't think splitting them up makes a whole lot of sense, when we do API changes like this we usually fix up all callers. So please try to fix your mailer, merged them all into one, and maybe also chose a more descriptive subject line, e.g. Subject: take checks for NULL and error pointers into posix_acl_valid() And btw, at least the XFS change seems incorrect - previously we returned NULL acl pointer and this patch changes it to -EINVAL.