All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Pitt <martin.pitt@ubuntu.com>
To: linux-hotplug@vger.kernel.org
Subject: CK.OpenSession(): Do not block on run-seat.d scripts?
Date: Mon, 21 Dec 2009 14:17:09 +0000	[thread overview]
Message-ID: <20091221141709.GA2268@piware.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]

Hello William,

I am currently investigating boot speed improvements, and one
particular item is that gdm hangs half a second in
ConsoleKit.OpenSession(). The reason is that it synchronously calls
all run-seat.d/* scripts, which includes udev-acl.ck.

I'm working on speeding up udev-acl.ck, but I need to discuss that
with Kay Sievers first.

However, I wondered why it is synchronous in the first place: The
hooks are called with a couple of environment variables, but CK does
not read any kind of result from them. In other words, the scripts
can't influence session properties, nor abort the creation of a
session.

Is there a particular reason for CK to wait on all the hooks? If not,
I'm happy to work on a patch to call those in the background. The only
thing to watch out for, as far as I can see, is that a call to the
hooks must not overlap with the next seat change, so this requires
some locking.

Thank you, and Merry Christmas,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

             reply	other threads:[~2009-12-21 14:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-21 14:17 Martin Pitt [this message]
2009-12-21 14:32 ` CK.OpenSession(): Do not block on run-seat.d scripts? Lennart Poettering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091221141709.GA2268@piware.de \
    --to=martin.pitt@ubuntu.com \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.