All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Alexander Strakh <strakh@ispras.ru>
Cc: Greg Kroah-Hartman <greg@kroah.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: BUG null dereference in driver ./drivers/usb/serial/mos7840.c
Date: Mon, 21 Dec 2009 08:20:02 -0800	[thread overview]
Message-ID: <20091221162002.GA7091@suse.de> (raw)
In-Reply-To: <200912211951.09832.strakh@ispras.ru>

On Mon, Dec 21, 2009 at 07:51:09PM +0000, Alexander Strakh wrote:
>         KERNEL_VERSION: 2.6.32
>         SUBJECT: null derefernce in function mos7840_bulk_in_callback
>         SUBSCRIBE:
>         In driver drivers/usb/serial/mos7840.c in function 
> mos7840_bulk_in_callback:
> 
> 1. If in line 697 mos7840_port = NULL then we goto line 699

How can that happen?

> 2. In line 699 we have null dereference.
> 
>  696         mos7840_port = urb->context;
>  697         if (!mos7840_port) {
>  698                 dbg("%s", "NULL mos7840_port pointer");
>  699                 mos7840_port->read_urb_busy = false;
>  700                 return;
>  701         }
> 
> Found by Linux Device Drivers Verification Project (Svace Detector)

What is this?

Are you also going to send patches for stuff like this?

thanks,

greg k-h

      reply	other threads:[~2009-12-21 16:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-21 19:51 BUG null dereference in driver ./drivers/usb/serial/mos7840.c Alexander Strakh
2009-12-21 16:20 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091221162002.GA7091@suse.de \
    --to=gregkh@suse.de \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=strakh@ispras.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.