All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carles Pina i Estany <carles@pina.cat>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: gettext: commands/*
Date: Mon, 21 Dec 2009 22:13:37 +0000	[thread overview]
Message-ID: <20091221221337.GA26409@pina.cat> (raw)
In-Reply-To: <4B2F6704.50107@gmail.com>


I've committed the patch. Notes:

On Dec/21/2009, Vladimir '??-coder/phcoder' Serbinenko wrote:
> === modified file 'commands/blocklist.c'
> --- commands/blocklist.c	2009-06-10 21:04:23 +0000
> +++ commands/blocklist.c	2009-12-21 00:09:02 +0000
> @@ -87,7 +87,7 @@ grub_cmd_blocklist (grub_command_t cmd _
>  
>    if (! file->device->disk)
>      return grub_error (GRUB_ERR_BAD_DEVICE,
> -		       "this command is available only for disk devices.");
> +		       "this command is available only for disk devices"); 
> Capitalisation and full stop

I'll talk about this in a new thread.

>    cmd = grub_register_command ("halt", grub_cmd_halt,
> -			       0, "halts the computer.  This command does not"
> +			       0, "Halts the computer.  This command does not"
>  			       " work on all firmware.");
> I would rather say "On *every* firmware."

I followed Watson suggestion


>  static const struct grub_arg_option options[] =
>    {
> -    {"file", 'f', 0, "specify filename", 0, ARG_TYPE_PATHNAME},
> +    {"file", 'f', 0, "Specify filename.", 0, ARG_TYPE_PATHNAME},
> Filename for what?

I'll add a comment when I will gettextizze it.

-- 
Carles Pina i Estany
	http://pinux.info



      parent reply	other threads:[~2009-12-21 22:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-06 18:22 gettext: commands/* Carles Pina i Estany
2009-12-07  0:49 ` Carles Pina i Estany
2009-12-07  8:44   ` Carles Pina i Estany
2009-12-07 23:23 ` Vladimir 'φ-coder/phcoder' Serbinenko
2009-12-21  0:21   ` Carles Pina i Estany
2009-12-21  0:47     ` Carles Pina i Estany
2009-12-21 12:16     ` Vladimir 'φ-coder/phcoder' Serbinenko
2009-12-21 12:37       ` Colin Watson
2009-12-21 16:17         ` Bruce Dubbs
2009-12-24 21:03           ` Robert Millan
2009-12-21 22:13       ` Carles Pina i Estany [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091221221337.GA26409@pina.cat \
    --to=carles@pina.cat \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.