From: Andrew Morton <akpm@linux-foundation.org>
To: "Smith, GeoffX" <geoffx.smith@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Arjan van de Ven <arjan@infradead.org>,
stable@kernel.org
Subject: Re: [PATCH] prctl: return timerslack through pointer
Date: Tue, 22 Dec 2009 13:50:41 -0800 [thread overview]
Message-ID: <20091222135041.b24abeff.akpm@linux-foundation.org> (raw)
In-Reply-To: <354B2877CF17F44BB3FA44EB4DB0E5470C91CE12F3@orsmsx510.amr.corp.intel.com>
On Thu, 17 Dec 2009 16:17:15 -0800
"Smith, GeoffX" <geoffx.smith@intel.com> wrote:
> This patch fixes the semantics of prctl() option PR_GET_TIMERSLACK
> to pass the return value through *arg2.
>
> With this change, the option now follows the same conventions as the
> other "get" options added since 2.6.0, and also brings it into
> conformance with the advice in chapter 16 of Documentation/CodingStyle.
>
> In addition, it effectively doubles the range of time slack to 4.29
> seconds (on a 32-bit architecture).
>
> The timer slack feature was only added in Sep 2009 (new in 2.6.32.1),
> so there are not any production applications to break. I have also
> repaired some unmatched signed/unsigned mismatches in timer slack
> calculations.
>
If we're going to do this then we should backport the patch into
2.6.32.x as well. And I agree that there is time to make this change.
> diff --git a/kernel/sys.c b/kernel/sys.c
> index 20ccfb5..e01da12 100644
You omitted the Signed-off-by: line (described in
Documentation/SubmittingPatches). Please send one.
next prev parent reply other threads:[~2009-12-22 21:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 0:17 [PATCH] prctl: return timerslack through pointer Smith, GeoffX
2009-12-22 21:50 ` Andrew Morton [this message]
2009-12-22 22:05 ` Smith, GeoffX
2009-12-22 22:51 ` Smith, GeoffX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091222135041.b24abeff.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=geoffx.smith@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.