From: Roger Luethi <rl@hellgate.ch>
To: Andrey Rahmatullin <wrar@altlinux.org>
Cc: Jarek Poplawski <jarkao2@gmail.com>,
Christian Kujau <lists@nerdbynature.de>,
LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: via_rhine kernel crashes in 2.6.32
Date: Tue, 22 Dec 2009 16:26:59 +0100 [thread overview]
Message-ID: <20091222152658.GA16043@core.hellgate.ch> (raw)
In-Reply-To: <20091222150045.GA5355@wrars-comp.wrarsdomain>
On Tue, 22 Dec 2009 20:00:45 +0500, Andrey Rahmatullin wrote:
> On Tue, Dec 22, 2009 at 01:38:17PM +0000, Jarek Poplawski wrote:
> > > > It looks like napi_disable() should be illegal in ndo_tx_timeout().
> > > > Here is a patch which moves most of the timeout work to a workqueue,
> > > > similarly to tg3 etc. It should prevent at least one of reported
> > > > bugs. Alas I can't even check-compile it at the moment, so let me
> > > > know on any problems.
> > > It seems I needlessly changed locking btw, so here it is again.
> > Hmm... On the other hand, it definitely needs at least _bh now...
> I've tried this patch. There are lots of "Transmit timed out", but no
> crashes.
ACK. Looks like you guys tracked down the crashing and fixed it (thanks!).
I suspect we shouldn't have to reset due to timeouts that often, but that's
another story.
Roger
next prev parent reply other threads:[~2009-12-22 15:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-19 11:12 via_rhine kernel crashes in 2.6.32 Andrey Rahmatullin
2009-12-20 20:03 ` Andrey Rahmatullin
2009-12-21 12:03 ` Christian Kujau
2009-12-21 12:36 ` Andrey Rahmatullin
2009-12-21 18:18 ` Andrey Rahmatullin
2009-12-21 19:32 ` Christian Kujau
2009-12-22 12:32 ` Jarek Poplawski
2009-12-22 13:21 ` Jarek Poplawski
2009-12-22 13:38 ` Jarek Poplawski
2009-12-22 15:00 ` Andrey Rahmatullin
2009-12-22 15:26 ` Roger Luethi [this message]
2009-12-22 17:36 ` [PATCH] net/via-rhine: Fix scheduling while atomic bugs Jarek Poplawski
2009-12-24 5:54 ` David Miller
2009-12-23 9:52 ` via_rhine kernel crashes in 2.6.32 Jarek Poplawski
2009-12-23 16:21 ` Andrey Rahmatullin
2009-12-23 16:30 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091222152658.GA16043@core.hellgate.ch \
--to=rl@hellgate.ch \
--cc=jarkao2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@nerdbynature.de \
--cc=netdev@vger.kernel.org \
--cc=wrar@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.