From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthias Kaehlcke <matthias@kaehlcke.net>
Date: Tue, 22 Dec 2009 17:28:26 +0100
Subject: [U-Boot] BUG_ON() uses macro unlikely(), which isn't defined
Message-ID: <20091222162826.GG32054@darwin>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

include/common.h defines the BUG_ON macro:

#define BUG_ON(condition) do { if (unlikely((condition)!=0)) BUG(); }
while(0)

this macro isn't defined in common.h or its includes

i'd submit a patch to fix this, but i wonder what kind of fix is
preferred:

a) eliminate the use of 'unlikely' in BUG_ON
b) define likely() and unlikely() in common.h
c) define likely() and unlikely() elsewhere
d) ?

best regards

-- 
Matthias Kaehlcke
Embedded Linux Developer
Barcelona

    C treats you like a consenting adult. Pascal treats you like a
          naughty child. Ada treats you like a criminal
                      (Bruce Powel Douglass)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-