From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
?????? <peb1611@gmail.com>
Subject: Re: I cannot get any message from domU by console / pv_ops domU kernel crashes with xen_create_contiguous_region failed
Date: Tue, 22 Dec 2009 13:08:20 -0500 [thread overview]
Message-ID: <20091222180820.GA31242@phenom.dumpdata.com> (raw)
In-Reply-To: <1261504973.5965.7226.camel@zakaz.uk.xensource.com>
> > void __init xen_swiotlb_init(void)
> > {
> > - if (xen_domain()) {
> > + int use_swiotlb = 0;
> > +
> > + if (xen_initial_domain())
> > + use_swiotlb = 1;
> > +
> > + /* For PV guest, only if iommu=soft is passed in. */
> > + if (xen_pv_domain() && !xen_initial_domain() && swiotlb)
> > + use_swiotlb = 1;
> > +
> > + if (use_swiotlb) {
>
> How about just
> if (xen_pv_domain() && (xen_initial_domain() || swiotlb))
That would work too. Let me remake the patch as it also has
spaces instead of tabs and fails the checkpatch.pl.
> Or depending on how/where swiotlb gets set (i.e. if it is set IFF
> xen_pv_domain) simply:
> if (xen_initial_domain() || swiotlb)
Can't do that, as it could on baremetal allocate the Xen-SWIOTLB.
>
> Ian.
>
next prev parent reply other threads:[~2009-12-22 18:08 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 14:30 I cannot get any message from domU by console 박은병
2009-12-21 18:30 ` Pasi Kärkkäinen
[not found] ` <ebf0d9030912212002h6996f725kf4626bd02e03161b@mail.gmail.com>
2009-12-22 8:42 ` I cannot get any message from domU by console / pv_ops domU kernel crashes with xen_create_contiguous_region failed Pasi Kärkkäinen
2009-12-22 9:20 ` Ian Campbell
2009-12-22 13:04 ` Michael D Labriola
2009-12-22 13:20 ` Michael D Labriola
2009-12-22 14:09 ` Ian Campbell
2009-12-22 13:33 ` 박은병
2009-12-22 14:35 ` Konrad Rzeszutek Wilk
2009-12-22 14:50 ` Ian Campbell
2009-12-22 15:47 ` Konrad Rzeszutek Wilk
2009-12-22 16:09 ` Ian Campbell
2009-12-22 16:19 ` Konrad Rzeszutek Wilk
2009-12-22 16:59 ` Konrad Rzeszutek Wilk
2009-12-22 18:02 ` Ian Campbell
2009-12-22 18:08 ` Konrad Rzeszutek Wilk [this message]
2009-12-22 14:32 ` Konrad Rzeszutek Wilk
2009-12-22 14:58 ` Ian Campbell
2009-12-22 15:27 ` Konrad Rzeszutek Wilk
2009-12-22 15:14 ` Michael D Labriola
2009-12-22 15:40 ` Konrad Rzeszutek Wilk
2009-12-22 16:44 ` Michael D Labriola
2009-12-22 16:55 ` Michael D Labriola
2009-12-22 17:00 ` Konrad Rzeszutek Wilk
2009-12-22 17:20 ` Michael D Labriola
2009-12-22 17:59 ` Michael D Labriola
2009-12-22 18:23 ` Konrad Rzeszutek Wilk
2009-12-22 18:47 ` Michael D Labriola
2009-12-22 19:14 ` Konrad Rzeszutek Wilk
2009-12-22 19:50 ` Michael D Labriola
2009-12-22 20:03 ` Ian Campbell
2009-12-22 21:00 ` Michael D Labriola
2009-12-22 20:07 ` Konrad Rzeszutek Wilk
2009-12-22 20:37 ` Konrad Rzeszutek Wilk
2009-12-22 21:49 ` Michael D Labriola
2009-12-23 18:49 ` Michael D Labriola
2009-12-23 20:15 ` Michael D Labriola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091222180820.GA31242@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=jeremy@goop.org \
--cc=peb1611@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.