From: "Michael S. Tsirkin" <mst@redhat.com>
To: Chris Wright <chrisw@sous-sol.org>
Cc: rusty@rustcorp.com.au, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] vhost-net: comment use of invalid fd when setting vhost backend
Date: Tue, 22 Dec 2009 21:37:49 +0200 [thread overview]
Message-ID: <20091222193749.GA20454@redhat.com> (raw)
In-Reply-To: <20091222181828.GA2095@sequoia.sous-sol.org>
On Tue, Dec 22, 2009 at 10:18:28AM -0800, Chris Wright wrote:
> This looks like an error case, but it's just a special case to shutdown
> the backend. Clarify with a comment.
>
> Signed-off-by: Chris Wright <chrisw@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/vhost/net.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
> index 22d5fef..cc92086 100644
> --- a/drivers/vhost/net.c
> +++ b/drivers/vhost/net.c
> @@ -465,6 +465,7 @@ static struct socket *get_tun_socket(int fd)
> static struct socket *get_socket(int fd)
> {
> struct socket *sock;
> + /* special case to disable backend */
> if (fd == -1)
> return NULL;
> sock = get_raw_socket(fd);
next prev parent reply other threads:[~2009-12-22 19:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 18:18 [PATCH] vhost-net: comment use of invalid fd when setting vhost backend Chris Wright
2009-12-22 19:37 ` Michael S. Tsirkin
2009-12-22 19:37 ` Michael S. Tsirkin [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-12-22 18:18 Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091222193749.GA20454@redhat.com \
--to=mst@redhat.com \
--cc=chrisw@sous-sol.org \
--cc=kvm@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.