From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 1 of 3] If Xen backend modules are not loaded, load them before starting Xend Date: Tue, 22 Dec 2009 14:57:53 -0500 Message-ID: <20091222195753.GB31761@phenom.dumpdata.com> References: <7bd805a543da685a3dba.1261500536@phenom.dumpdata.com> <1261510877.27802.19.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1261510877.27802.19.camel@localhost.localdomain> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: "xen-devel@lists.xensource.com" , Keir Fraser List-Id: xen-devel@lists.xenproject.org On Tue, Dec 22, 2009 at 07:41:17PM +0000, Ian Campbell wrote: > On Tue, 2009-12-22 at 16:48 +0000, Konrad Rzeszutek Wilk wrote: > > @@ -28,6 +28,7 @@ > > grep ' xenfs$' /proc/filesystems >/dev/null && \ > > ! grep '^xenfs ' /proc/mounts >/dev/null; > > then > > + modprobe -q xenfs > > mount -t xenfs xenfs /proc/xen > > fi > > > > I think this one gets requested automatically if the filesystem isn't > currently present, see the call to request_module in > fs/filesystems.c:get_fs_type() Hmm, in 2.6.32 it looks to be usuable only once the filesystem has loaded. This patch is for the case where the filesystem (xenfs) is compiled as a module - and had not been loaded. Hence hadn't had a chance to call fs/filesystem.c:register_filesystem(). Thought maybe I messing up this up. The "grep 'xenfs$' /proc/filesystem" checks for xenfs in /proc/filesystem so it should not even get to the "then" statement. Something is fishy here. Why don't we skip this patch and I will revist it after holidays.