From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 3 of 3] [xen-detect] Add arguments to print
	out only outputs we are interested in
Date: Tue, 22 Dec 2009 15:26:03 -0500
Message-ID: <20091222202603.GB11542@phenom.dumpdata.com>
References: <04c067941b17bdc679ff.1261500538@phenom.dumpdata.com>
	<C756DABA.5191%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <C756DABA.5191%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, Dec 22, 2009 at 08:21:14PM +0000, Keir Fraser wrote:
> On 22/12/2009 16:48, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com> wrote:
> 
> > # HG changeset patch
> > # User konrad@phenom.dumpdata.com
> > # Date 1261498156 18000
> > # Node ID 04c067941b17bdc679ffdc2f6c81f8e2f78e9cc5
> > # Parent  7bd805a543da685a3dba7b8b0c4e3e7052c863b3
> > [xen-detect] Add arguments to print out only outputs we are interested in.
> > 
> > This is quite usefull in scripts where you can do
> > if xen-detect -P || modprobe xen-<some module>
> > 
> > And do not have to parse the output - instead you will get
> > the output only if the condition exists.
> 
> Er, what? The above shell fragment is affected by the value returned by
> xen-detect (0 versus non-0), not by whether it prints something!

Wrong combination. Here is what the Dracut maintainer suggested:

[konrad@phenom ~]$ if xen-detect; then echo blah; fi
Not running on Xen.
blah

Which is not what I wanted it to do. Having the -N, -P, -H arguments
fixed the issue.

> 
> Here is my suggestion: keep your new command-line options, but instead of
> affecting printing, have them affect the return value. E.g., -P causes
> return 0 if running PV, else return 1. Further, we can add a -q option to
> quiesce normal output from xen-detect, to make it quieter for use in shell
> scripts.
> 
> E.g, xen-detect -Pq && modprobe some-xen-pv-specific-module
> 
> What do you think of that?

That should do it. Will post a rework after the X-mas holidays.