From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from kernel.dk (0122700014.0.fullrate.dk [95.166.99.235]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTPS id 317961072E9B for ; Tue, 22 Dec 2009 22:41:14 +0100 (CET) Date: Tue, 22 Dec 2009 22:41:12 +0100 From: Jens Axboe To: Andrew Morton Message-ID: <20091222214112.GV4489@kernel.dk> References: <200912220027.nBM0Rrsj005415@imap1.linux-foundation.org> <200912221007.50695.philipp.reisner@linbit.com> <20091222091307.GJ4489@kernel.dk> <20091222092223.8e44a621.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091222092223.8e44a621.akpm@linux-foundation.org> Cc: roel.kluin@gmail.com, Philipp Reisner , drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [patch 5/5] drbd: fix test of unsigned in _drbd_fault_random() List-Id: Coordination of development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Dec 22 2009, Andrew Morton wrote: > On Tue, 22 Dec 2009 10:13:07 +0100 Jens Axboe wrote: > > > On Tue, Dec 22 2009, Philipp Reisner wrote: > > > Am Dienstag, 22. Dezember 2009 01:27:52 schrieb akpm@linux-foundation.org: > > > > From: Roel Kluin > > > > > > > > rsp->count is unsigned so the test does not work. > > > > > > > > Signed-off-by: Roel Kluin > > > [...] > > > > > > This patch is on its way upstream > > > See http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=49829ea74f790d3be2e803a617e714f5b9a5ed50 > > > > > > and in the DRBD tree for old kernels... > > > http://git.drbd.org/?p=drbd-8.3.git;a=commit;h=f1cb8ce303a26e4763bbfb32660643322f4e228d > > > > Indeed, it's been in my for-linus/next for a while, I'm guessing Andrew > > just hasn't updated his sources for some days. > > > > I pull linux-next every day. > > The above patch wasn't in the Dec 19 linux-next, and Stephen won't be > doing another -next until Dec 29. Oh, so that's why. We/I used to have for-akpm, but with -next that has become more tricky (since you base on that). Anyway, not an issue for me, the only change is having to notify about merged patches for the odd ball periods like now were Stephen isn't doing daily releases. -- Jens Axboe