From: Simon Horman <horms@verge.net.au>
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [patch 4/7] [patch] rtl8192e: print the elements of tx_pn and rx_pn not the arrays themselves
Date: Wed, 23 Dec 2009 19:54:52 +1100 [thread overview]
Message-ID: <20091223085552.784470965@vergenet.net> (raw)
In-Reply-To: 20091223085448.619253793@vergenet.net
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: rtl8192e-printk-array.patch --]
[-- Type: text/plain, Size: 2186 bytes --]
Signed-off-by: Simon Horman <horms@verge.net.au>
---
Compile tested only
$ gcc --versino
gcc (Debian 4.4.2-6) 4.4.2
Copyright (C) 2009 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
$ make
...
drivers/staging/rtl8192e/ieee80211/ieee80211_crypt_ccmp.c: In function ‘ieee80211_ccmp_print_stats’:
drivers/staging/rtl8192e/ieee80211/ieee80211_crypt_ccmp.c:486: warning: format ‘%02x’ expects type ‘unsigned int’, but argument 5 has type ‘u8 *’
drivers/staging/rtl8192e/ieee80211/ieee80211_crypt_ccmp.c:486: warning: format ‘%02x’ expects type ‘unsigned int’, but argument 6 has type ‘u8 *’
drivers/staging/rtl8192e/ieee80211/ieee80211_crypt_ccmp.c:486: warning: too few arguments for format
Index: gregkh-2.6/drivers/staging/rtl8192e/ieee80211/ieee80211_crypt_ccmp.c
===================================================================
--- gregkh-2.6.orig/drivers/staging/rtl8192e/ieee80211/ieee80211_crypt_ccmp.c 2009-12-23 18:39:52.000000000 +1100
+++ gregkh-2.6/drivers/staging/rtl8192e/ieee80211/ieee80211_crypt_ccmp.c 2009-12-23 19:35:07.000000000 +1100
@@ -475,12 +475,19 @@ static int ieee80211_ccmp_get_key(void *
static char * ieee80211_ccmp_print_stats(char *p, void *priv)
{
struct ieee80211_ccmp_data *ccmp = priv;
- p += sprintf(p, "key[%d] alg=CCMP key_set=%d "
- "tx_pn=%02x%02x%02x%02x%02x%02x "
- "rx_pn=%02x%02x%02x%02x%02x%02x "
- "format_errors=%d replays=%d decrypt_errors=%d\n",
- ccmp->key_idx, ccmp->key_set,
- ccmp->tx_pn, ccmp->rx_pn,
+ int i;
+
+ p += sprintf(p, "key[%d] alg=CCMP key_set=%d tx_pn=",
+ ccmp->key_idx, ccmp->key_set);
+
+ for (i = 0; i < ARRAY_SIZE(ccmp->tx_pn); i++)
+ p += sprintf(p, "%02x", ccmp->tx_pn[i]);
+
+ sprintf(p, " rx_pn=");
+ for (i = 0; i < ARRAY_SIZE(ccmp->rx_pn); i++)
+ p += sprintf(p, "%02x", ccmp->tx_pn[i]);
+
+ p += sprintf(p, " format_errors=%d replays=%d decrypt_errors=%d\n",
ccmp->dot11RSNAStatsCCMPFormatErrors,
ccmp->dot11RSNAStatsCCMPReplays,
ccmp->dot11RSNAStatsCCMPDecryptErrors);
next prev parent reply other threads:[~2009-12-23 8:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 8:54 [patch 0/7] minor cleanups for various staging drivers Simon Horman
2009-12-23 8:54 ` [patch 1/7] [patch] DT3155: Use pci_get_device Simon Horman
2009-12-23 16:19 ` Greg KH
2009-12-23 22:02 ` Simon Horman
2009-12-23 23:37 ` Greg KH
2009-12-24 2:11 ` Simon Horman
2009-12-23 8:54 ` [patch 2/7] [patch] rt2870: rtusb_probe() should be in section __devinit Simon Horman
2009-12-23 8:54 ` [patch 3/7] [patch] rt2870: Remove unnecessary forward declarations Simon Horman
2009-12-23 8:54 ` Simon Horman [this message]
2009-12-23 8:54 ` [patch 5/7] [patch] rtl8192e: remove some functions from the __exit section Simon Horman
2009-12-23 8:54 ` [patch 6/7] [patch] rtl8192su, rtl8192u: use min_t() in store_debug_level() Simon Horman
[not found] ` <20091223085553.648368336@vergenet.net>
2009-12-23 10:39 ` [patch 7/7] [patch] rtl8192u: Clarify logic in‘ieee80211_wx_get_encode_ext_rsl() Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091223085552.784470965@vergenet.net \
--to=horms@verge.net.au \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.