From: Christoph Hellwig <hch@infradead.org>
To: Bill Kendall <wkendall@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] use time32_t consistently in xfsdump tree
Date: Wed, 23 Dec 2009 08:31:36 -0500 [thread overview]
Message-ID: <20091223133136.GA10345@infradead.org> (raw)
In-Reply-To: <4B300389.7020905@sgi.com>
On Mon, Dec 21, 2009 at 05:23:53PM -0600, Bill Kendall wrote:
> xfsdump stores time_t as 32-bits in its dump and inventory
> structures for portability/historical reasons. xfsinvutil
> uses time_t directly, leading to some strange results on
> systems which have a 64-bit time_t.
>
> The 32-bit time-related functions were factored out into
> their own file since they are now used by xfsinvutil, and
> their original file (util.c) could not easily be linked
> with xfsinvutil due to dependencies on many other
> dump/restore modules.
The newly created timeutil.[ch] did not get included into the patch,
so I can't easily review them, and the rest of the patch also seems
whitespace mangled to me.
The changes in it looks good, just the time_t to time32_t conversions
plus overflow checks.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-12-23 13:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 23:23 [PATCH] use time32_t consistently in xfsdump tree Bill Kendall
2009-12-23 13:31 ` Christoph Hellwig [this message]
2009-12-23 15:09 ` Bill Kendall
2009-12-23 17:15 ` Bill Kendall
2009-12-23 17:41 ` Bill Kendall
2010-01-06 17:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091223133136.GA10345@infradead.org \
--to=hch@infradead.org \
--cc=wkendall@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.