All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: grub-devel@gnu.org
Subject: Re: grub_elf32_size()
Date: Thu, 24 Dec 2009 22:22:04 +0100	[thread overview]
Message-ID: <20091224212204.GJ12122@thorin> (raw)
In-Reply-To: <20091211232016.GA12276@thorin>


It seems this just didn't belong to relocator branch.  Nothing to see here ;-)

On Sat, Dec 12, 2009 at 12:20:17AM +0100, Robert Millan wrote:
> 
> Not sure if I missed something obvious, but this commit (relocator branch)
> seems to break compilation rather than fix it.  Was grub_elf32_size()
> number of args meant to be changed?
> 
> -- 
> Robert Millan
> 
>   The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
>   how) you may access your data; but nobody's threatening your freedom: we
>   still allow you to remove your data and not access it at all."

> ------------------------------------------------------------
> revno: 1899
> committer: Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>
> branch nick: relocators
> timestamp: Thu 2009-12-03 22:45:41 +0100
> message:
>   Fix compilation issue for ppc
> 
> === modified file 'loader/powerpc/ieee1275/linux.c'
> --- loader/powerpc/ieee1275/linux.c	2009-06-21 23:55:23 +0000
> +++ loader/powerpc/ieee1275/linux.c	2009-12-03 21:45:41 +0000
> @@ -110,7 +110,7 @@ grub_linux_load32 (grub_elf_t elf)
>    if (entry == 0)
>      entry = 0x01400000;
>  
> -  linux_size = grub_elf32_size (elf);
> +  linux_size = grub_elf32_size (elf, 0);
>    if (linux_size == 0)
>      return grub_errno;
>    /* Pad it; the kernel scribbles over memory beyond its load address.  */
> @@ -160,7 +160,7 @@ grub_linux_load64 (grub_elf_t elf)
>    if (entry == 0)
>      entry = 0x01400000;
>  
> -  linux_size = grub_elf64_size (elf);
> +  linux_size = grub_elf64_size (elf, 0);
>    if (linux_size == 0)
>      return grub_errno;
>    /* Pad it; the kernel scribbles over memory beyond its load address.  */
> 

> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Robert Millan

  "Be the change you want to see in the world" -- Gandhi



      reply	other threads:[~2009-12-24 21:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11 23:20 grub_elf32_size() Robert Millan
2009-12-24 21:22 ` Robert Millan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091224212204.GJ12122@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.