From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NNvZc-0001yW-Gp for mharc-grub-devel@gnu.org; Thu, 24 Dec 2009 16:50:20 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NNvZb-0001yO-17 for grub-devel@gnu.org; Thu, 24 Dec 2009 16:50:19 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NNvZW-0001xw-J1 for grub-devel@gnu.org; Thu, 24 Dec 2009 16:50:18 -0500 Received: from [199.232.76.173] (port=39125 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NNvZW-0001xt-DF for grub-devel@gnu.org; Thu, 24 Dec 2009 16:50:14 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:55084 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NNvZV-00056z-QE for grub-devel@gnu.org; Thu, 24 Dec 2009 16:50:14 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NNvZU-00009t-Hb for grub-devel@gnu.org; Thu, 24 Dec 2009 22:50:12 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NNvZT-0003JJ-MX for grub-devel@gnu.org; Thu, 24 Dec 2009 22:50:11 +0100 Date: Thu, 24 Dec 2009 22:50:11 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20091224215011.GP12122@thorin> References: <4B30D3B9.2010705@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4B30D3B9.2010705@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] byte-addressable grub_pci_make_address X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Dec 2009 21:50:19 -0000 On Tue, Dec 22, 2009 at 03:12:09PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > === modified file 'commands/efi/loadbios.c' > --- commands/efi/loadbios.c 2009-12-21 22:06:04 +0000 > +++ commands/efi/loadbios.c 2009-12-22 12:03:12 +0000 > @@ -50,7 +50,7 @@ > return 0; > } > > - addr = grub_pci_make_address (dev, 36); > + addr = grub_pci_make_address (dev, 144); > grub_pci_write_byte (addr++, 0x30); > grub_pci_write_byte (addr++, 0x33); > grub_pci_write_byte (addr++, 0x33); > @@ -76,7 +76,7 @@ > grub_pci_address_t addr; > grub_pci_device_t dev = { .bus = 0, .device = 0, .function = 0}; > > - addr = grub_pci_make_address (dev, 36); > + addr = grub_pci_make_address (dev, 144); These look like black magic. Could they be macroified instead? -- Robert Millan "Be the change you want to see in the world" -- Gandhi