From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [patch 00/11] convert slotslock to SRCU v2 Date: Fri, 25 Dec 2009 10:25:00 -0200 Message-ID: <20091225122500.GA4693@amt.cnet> References: <20091223163515.215618069@redhat.com> <4B3326A0.4080708@redhat.com> <20091224145638.GC5691@redhat.com> <200912251524.49261.sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, Gleb Natapov , Avi Kivity To: Sheng Yang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:49904 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755339AbZLYPlz (ORCPT ); Fri, 25 Dec 2009 10:41:55 -0500 Content-Disposition: inline In-Reply-To: <200912251524.49261.sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Dec 25, 2009 at 03:24:49PM +0800, Sheng Yang wrote: > On Thursday 24 December 2009 22:56:38 Gleb Natapov wrote: > > On Thu, Dec 24, 2009 at 10:30:24AM +0200, Avi Kivity wrote: > > > On 12/23/2009 06:35 PM, Marcelo Tosatti wrote: > > > >Addressing comments. > > > > > > Looks good. > > > > Looks good to me too. > > One small comment on the naming: > > kvm->memslots->memslots[i] > kvm->aliases->aliases[i] > > Doesn't look good... Hi Sheng, Yes its somewhat confusing but i could not come up with anything better. Suggestions?