All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikola Ciprich <extmaillist@linuxbox.cz>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: nikola.ciprich@linuxbox.cz, KVM list <kvm@vger.kernel.org>
Subject: Re: [ANNOUNCE] qemu-kvm-0.12.1.1
Date: Fri, 25 Dec 2009 13:46:09 +0100	[thread overview]
Message-ID: <20091225124609.GA4508@nik-comp.linuxbox.cz> (raw)
In-Reply-To: <20091224162511.GA14150@amt.cnet>

Hi Marcelo,
Avi has already fixed this particular problem in the meantime, but
I checked and your patch fixes build problem as well..
thanks!
have a nice day
nik

On Thu, Dec 24, 2009 at 02:25:11PM -0200, Marcelo Tosatti wrote:
> On Tue, Dec 22, 2009 at 03:07:36PM +0100, Nikola Ciprich wrote:
> > CentOS5, all packages updated.
> > But I just noticed build fails only when configured with multiple targets,
> > including some more exotic (based on fedora spec).
> > building just using x86_64-softmmu works fine for me.
> > n.
> > On Tue, Dec 22, 2009 at 03:43:32PM +0200, Avi Kivity wrote:
> > > On 12/22/2009 03:35 PM, Nikola Ciprich wrote:
> > > >sorry to bring bad news, but it still doesn't compile (at least for me):
> > > >
> > > >[root@vmdev03 qemu-kvm-0.12.1.1]# make
> > > >   LINK  x86_64-softmmu/qemu-system-x86_64
> > > >machine.o: In function `cpu_pre_save':
> > > >/usr/src/redhat/BUILD/qemu-kvm-0.12.1.1/target-i386/machine.c:326: undefined reference to `kvm_save_mpstate'
> > > >collect2: ld returned 1 exit status
> > > >make[1]: *** [qemu-system-x86_64] Error 1
> > > >make: *** [subdir-x86_64-softmmu] Error 2
> 
> Nikola,
> 
> Can you please confirm the attached patch fixes the undefined reference
> problem for you?
> 
> Thanks
> 

> diff --git a/qemu-kvm.h b/qemu-kvm.h
> index a81ff12..6b3e5a1 100644
> --- a/qemu-kvm.h
> +++ b/qemu-kvm.h
> @@ -1070,6 +1070,7 @@ void kvm_load_tsc(CPUState *env);
>  #endif
>  #define kvm_load_registers(env) do {} while(0)
>  #define kvm_save_registers(env) do {} while(0)
> +#define kvm_save_mpstate(env)   do {} while(0)
>  #define qemu_kvm_cpu_stop(env) do {} while(0)
>  static inline void kvm_init_vcpu(CPUState *env)
>  {


-- 
-------------------------------------
Nikola CIPRICH
LinuxBox.cz, s.r.o.
28. rijna 168, 709 01 Ostrava

tel.:   +420 596 603 142
fax:    +420 596 621 273
mobil:  +420 777 093 799

www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: servis@linuxbox.cz
-------------------------------------

  parent reply	other threads:[~2009-12-25 12:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-22 12:50 [ANNOUNCE] qemu-kvm-0.12.1.1 Avi Kivity
2009-12-22 13:35 ` Nikola Ciprich
2009-12-22 13:43   ` Avi Kivity
2009-12-22 14:07     ` Nikola Ciprich
2009-12-22 14:09       ` Avi Kivity
     [not found]       ` <20091224162511.GA14150@amt.cnet>
2009-12-25 12:46         ` Nikola Ciprich [this message]
2009-12-23  8:16 ` Thomas Treutner
2009-12-23  8:52   ` Avi Kivity
2009-12-23 10:15     ` Thomas Treutner
2009-12-23 10:24       ` Avi Kivity
2009-12-23 10:58         ` Thomas Treutner
2009-12-23 11:37           ` Avi Kivity
2010-01-04 15:22             ` Gerd Hoffmann
2010-01-04 15:22               ` [Qemu-devel] " Gerd Hoffmann
2010-01-04 15:52               ` Michael S. Tsirkin
2010-01-04 15:52                 ` [Qemu-devel] " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091225124609.GA4508@nik-comp.linuxbox.cz \
    --to=extmaillist@linuxbox.cz \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=nikola.ciprich@linuxbox.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.