From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sheng Yang <sheng@linux.intel.com>
Subject: Re: [patch 00/11] convert slotslock to SRCU v2
Date: Fri, 25 Dec 2009 15:24:49 +0800
Message-ID: <200912251524.49261.sheng@linux.intel.com>
References: <20091223163515.215618069@redhat.com> <4B3326A0.4080708@redhat.com> <20091224145638.GC5691@redhat.com>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: Gleb Natapov <gleb@redhat.com>, Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>
To: kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mga07.intel.com ([143.182.124.22]:39097 "EHLO
	azsmga101.ch.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1750957AbZLYHZb (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 25 Dec 2009 02:25:31 -0500
In-Reply-To: <20091224145638.GC5691@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thursday 24 December 2009 22:56:38 Gleb Natapov wrote:
> On Thu, Dec 24, 2009 at 10:30:24AM +0200, Avi Kivity wrote:
> > On 12/23/2009 06:35 PM, Marcelo Tosatti wrote:
> > >Addressing comments.
> >
> > Looks good.
> 
> Looks good to me too.

One small comment on the naming:

kvm->memslots->memslots[i]
kvm->aliases->aliases[i]

Doesn't look good...

-- 
regards
Yang, Sheng