From: tytso@mit.edu
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: "Yin, Kangkai" <kangkai.yin@intel.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] jbd: jbd-debug and jbd2-debug should be writable.
Date: Fri, 25 Dec 2009 15:48:59 -0500 [thread overview]
Message-ID: <20091225204859.GG32757@thunk.org> (raw)
In-Reply-To: <20091204094932.GC4272@skywalker.linux.vnet.ibm.com>
The ext4 portion has been added to the ext4 patch queue.
Jan, you want to add this to the ext3 tree?
- Ted
jbd: /sys/kernel/debug/jbd/jbd-debug should be writable.
From: "Yin, Kangkai" <kangkai.yin@intel.com>
Make this sysfs file writeable so we can enable debugging without
needing to reboot and futzing with boot command-line option.
Signed-off-by: Yin Kangkai <kangkai.yin@intel.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
fs/jbd/journal.c | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
index 4160afa..bd224ee 100644
--- a/fs/jbd/journal.c
+++ b/fs/jbd/journal.c
@@ -1913,7 +1913,7 @@ static void __init jbd_create_debugfs_entry(void)
{
jbd_debugfs_dir = debugfs_create_dir("jbd", NULL);
if (jbd_debugfs_dir)
- jbd_debug = debugfs_create_u8("jbd-debug", S_IRUGO,
+ jbd_debug = debugfs_create_u8("jbd-debug", S_IRUGO | S_IWUSR,
jbd_debugfs_dir,
&journal_enable_debug);
}
next prev parent reply other threads:[~2009-12-25 20:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 3:17 [PATCH] jbd: jbd-debug and jbd2-debug should be writable Yin, Kangkai
2009-12-04 9:49 ` Aneesh Kumar K.V
2009-12-25 20:48 ` tytso [this message]
2010-01-04 22:26 ` Jan Kara
2010-01-05 16:35 ` tytso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091225204859.GG32757@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=jack@suse.cz \
--cc=kangkai.yin@intel.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.