From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [patch 00/11] convert slotslock to SRCU v2 Date: Sat, 26 Dec 2009 02:22:43 +0800 Message-ID: <200912260222.43888.sheng@linux.intel.com> References: <20091223163515.215618069@redhat.com> <20091225122500.GA4693@amt.cnet> <4B34E7DF.4070104@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, Gleb Natapov To: Avi Kivity Return-path: Received: from mga12.intel.com ([143.182.124.36]:38255 "EHLO azsmga102.ch.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756090AbZLYSX2 (ORCPT ); Fri, 25 Dec 2009 13:23:28 -0500 In-Reply-To: <4B34E7DF.4070104@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Saturday 26 December 2009 00:27:11 Avi Kivity wrote: > On 12/25/2009 02:25 PM, Marcelo Tosatti wrote: > >> One small comment on the naming: > >> > >> kvm->memslots->memslots[i] > >> kvm->aliases->aliases[i] > >> > >> Doesn't look good... > > > > Hi Sheng, > > > > Yes its somewhat confusing but i could not come up with > > anything better. Suggestions? > > Could all it 'mem', and put both ->memslots and ->aliases as members. > This might simplify things a bit. > > However, I don't recommend doing so now, it's just churn. We can always > to it later. Yes. Just happen to see it, and feel a little uneasy... :) -- regards Yang, Sheng