From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NOWgj-00014u-0B for mharc-grub-devel@gnu.org; Sat, 26 Dec 2009 08:28:09 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NOWgh-00011u-Dg for grub-devel@gnu.org; Sat, 26 Dec 2009 08:28:07 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NOWgc-0000sJ-QO for grub-devel@gnu.org; Sat, 26 Dec 2009 08:28:06 -0500 Received: from [199.232.76.173] (port=39199 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NOWgc-0000sA-IV for grub-devel@gnu.org; Sat, 26 Dec 2009 08:28:02 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:48711 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NOWgc-0005Qd-9v for grub-devel@gnu.org; Sat, 26 Dec 2009 08:28:02 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NOWga-0005YM-Rk for grub-devel@gnu.org; Sat, 26 Dec 2009 14:28:01 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NOWga-0005P5-7g for grub-devel@gnu.org; Sat, 26 Dec 2009 14:28:00 +0100 Date: Sat, 26 Dec 2009 14:28:00 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20091226132800.GB20730@thorin> References: <20091224215526.GQ12122@thorin> <1261761718.3156.15.camel@fz.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1261761718.3156.15.camel@fz.local> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: Fix for grub_assert_fail undefined on NetBSD and other platforms X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Dec 2009 13:28:07 -0000 On Fri, Dec 25, 2009 at 06:21:58PM +0100, Felix Zielcke wrote: > Am Donnerstag, den 24.12.2009, 22:55 +0100 schrieb Robert Millan: > > On Tue, Dec 22, 2009 at 09:39:07PM +0530, BVK Chaitanya wrote: > > > Hi > > > > > > > > > Attached is the patch, which removes use of undefined > > grub_assert_fail > > > function for catching bad-type-cast errors, with a better version > > > __attribute__((error("msg"))) gcc extension. With this extension, > > gcc > > > can give the exact location of the bad type cast at compile time. > > > > Is this really a kind of error we'd like to report at run time? Sorry > > if > > I'm missing something, but if we need additional code to handle it, > > and it > > was known at compile time, why do we do this? > > __attribute__ ((error)) still reports it at compile time just like the > old grub_assert_fail method. > But the advantage is that you can specify the error message instead of > just getting a `ld: unknown symbol grub_assert_fail' error during > linking. And as BVK said above also the exact location where this > happened. Oh, ok. Seems fine then. -- Robert Millan "Be the change you want to see in the world" -- Gandhi