From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NOWyy-0000a7-8S for mharc-grub-devel@gnu.org; Sat, 26 Dec 2009 08:47:00 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NOWyv-0000Za-T7 for grub-devel@gnu.org; Sat, 26 Dec 2009 08:46:57 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NOWyq-0000Yy-CI for grub-devel@gnu.org; Sat, 26 Dec 2009 08:46:56 -0500 Received: from [199.232.76.173] (port=52510 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NOWyq-0000Yu-77 for grub-devel@gnu.org; Sat, 26 Dec 2009 08:46:52 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:51366 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NOWyp-0006vK-Qq for grub-devel@gnu.org; Sat, 26 Dec 2009 08:46:52 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NOWyn-0005fg-Qk for grub-devel@gnu.org; Sat, 26 Dec 2009 14:46:49 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NOWyn-0005R1-AO for grub-devel@gnu.org; Sat, 26 Dec 2009 14:46:49 +0100 Date: Sat, 26 Dec 2009 14:46:49 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20091226134649.GE20730@thorin> References: <20091226003553.GA5373@pina.cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091226003553.GA5373@pina.cat> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: regression fix X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Dec 2009 13:46:58 -0000 On Sat, Dec 26, 2009 at 01:35:53AM +0100, Carles Pina i Estany wrote: > > Hi, > > Commit 1949 introduced a bug using TAB due a miss-understanding that I > had with the code. Oh, good to know. I was wondering why TAB expansion did these weird things ;-) > - plen = grub_strlen (prompt_translated); > + plen = grub_strlen (prompt_translated) + 1; Please consider if sizeof() would make sense here. -- Robert Millan "Be the change you want to see in the world" -- Gandhi