From: "Shawn O. Pearce" <spearce@spearce.org>
To: Tarmigan <tarmigan+git@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, rctay89@gmail.com, drizzd@aon.at,
warthog9@kernel.org
Subject: Re: [PATCH 2/2] Smart-http: check if repository is OK to export before serving it
Date: Mon, 28 Dec 2009 07:59:31 -0800 [thread overview]
Message-ID: <20091228155931.GC2252@spearce.org> (raw)
In-Reply-To: <905315640912272007i8b4904dv2b93879789b453fb@mail.gmail.com>
Tarmigan <tarmigan+git@gmail.com> wrote:
> On Sun, Dec 27, 2009 at 4:10 PM, Shawn O. Pearce <spearce@spearce.org> wrote:
> > Tarmigan Casebolt <tarmigan+git@gmail.com> wrote:
> >> Similar to how git-daemon checks whether a repository is OK to be
> >> exported, smart-http should also check. ?This check can be satisfied
> >> in two different ways: the environmental variable GIT_HTTP_EXPORT_ALL
> >> may be set to export all repositories, or the individual repository
> >> may have the file git-daemon-export-ok.
...
> I've been thinking that the not_found() to a forbidden() instead.
Oh. Interesting question.
Because you can't resolve the access error by authenticating to
the server, we may actually want to just return not_found() here
with a message in the log of "Repository not exported: '%s'".
That would mirror the behavior of git-daemon.
--
Shawn.
next prev parent reply other threads:[~2009-12-28 15:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-26 16:21 Does smart-http need git-daemon-export-ok? Tarmigan
2009-12-26 17:33 ` Junio C Hamano
2009-12-26 23:29 ` [PATCH 1/2] Smart-http: Add tests and documentation for export-ok Tarmigan Casebolt
2009-12-26 23:29 ` [PATCH 2/2] Smart-http: check if repository is OK to export before serving it Tarmigan Casebolt
2009-12-27 21:10 ` Shawn O. Pearce
2009-12-28 4:07 ` Tarmigan
2009-12-28 4:22 ` [PATCH] " Tarmigan Casebolt
2009-12-28 15:59 ` Shawn O. Pearce [this message]
2009-12-28 16:57 ` [PATCH 2/2] " Tarmigan
2009-12-28 17:08 ` Shawn O. Pearce
2009-12-28 21:49 ` [PATCH] " Tarmigan Casebolt
2009-12-29 9:19 ` Junio C Hamano
2009-12-29 15:00 ` Shawn O. Pearce
2009-12-27 21:06 ` Does smart-http need git-daemon-export-ok? Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091228155931.GC2252@spearce.org \
--to=spearce@spearce.org \
--cc=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rctay89@gmail.com \
--cc=tarmigan+git@gmail.com \
--cc=warthog9@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.