From: Dan Carpenter <error27@gmail.com>
To: linux-media@vger.kernel.org, devel@driverdev.osuosl.org
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Subject: [patch] cx25821: fix double unlock in medusa_video_init()
Date: Mon, 28 Dec 2009 18:59:46 +0200 [thread overview]
Message-ID: <20091228165946.GD17645@bicker> (raw)
medusa_set_videostandard() takes the lock but it always drops it before
returning.
This was found with a static checker and compile tested only. :/
Signed-off-by: Dan Carpenter <error27@gmail.com>
--- orig/drivers/staging/cx25821/cx25821-medusa-video.c 2009-12-28 09:13:01.000000000 +0200
+++ devel/drivers/staging/cx25821/cx25821-medusa-video.c 2009-12-28 09:13:55.000000000 +0200
@@ -860,10 +860,8 @@ int medusa_video_init(struct cx25821_dev
ret_val = medusa_set_videostandard(dev);
- if (ret_val < 0) {
- mutex_unlock(&dev->lock);
+ if (ret_val < 0)
return -EINVAL;
- }
return 1;
}
reply other threads:[~2009-12-28 17:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091228165946.GD17645@bicker \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.