From: Dan Carpenter <error27@gmail.com>
To: Matthias Schwarzott <zzam@gentoo.org>
Cc: linux-media@vger.kernel.org, Matthias Schwarzott <zzam@gentoo.de>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: [patch] fix weird array index in zl10036.c
Date: Mon, 28 Dec 2009 19:48:49 +0200 [thread overview]
Message-ID: <20091228174849.GG17645@bicker> (raw)
In-Reply-To: <200912271802.46083.zzam@gentoo.org>
I was initially concerned about the weird array index (the 2 bumps
into the next row of the array). Matthias Schwarzott look at the
datasheet and it turns out it should be zl10036_init_tab[1][0] |= 0x01;
Signed-off-by: Dan Carpenter <error27@gmail.com>
--- orig/drivers/media/dvb/frontends/zl10036.c 2009-12-28 19:04:51.000000000 +0200
+++ devel/drivers/media/dvb/frontends/zl10036.c 2009-12-28 19:07:18.000000000 +0200
@@ -411,7 +411,7 @@ static int zl10036_init_regs(struct zl10
state->bf = 0xff;
if (!state->config->rf_loop_enable)
- zl10036_init_tab[1][2] |= 0x01;
+ zl10036_init_tab[1][0] |= 0x01;
deb_info("%s\n", __func__);
next prev parent reply other threads:[~2009-12-28 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-27 13:15 weird array index in zl10036.c Dan Carpenter
2009-12-27 17:02 ` Matthias Schwarzott
2009-12-28 17:48 ` Dan Carpenter [this message]
2009-12-29 10:08 ` [patch] fix " Matthias Schwarzott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091228174849.GG17645@bicker \
--to=error27@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=zzam@gentoo.de \
--cc=zzam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.