Re: [PATCH 1/2] arm: omap1: mailbox: kill compile warning

[Tony Lindgren <tony@atomide.com>]

* Felipe Balbi <felipe.balbi@nokia.com> [091222 12:17]:
> use ioremap to get the virtual address and
> avoid a compile warning.
> 
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
>  arch/arm/mach-omap1/mailbox.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-omap1/mailbox.c b/arch/arm/mach-omap1/mailbox.c
> index caf889a..38a7d2c 100644
> --- a/arch/arm/mach-omap1/mailbox.c
> +++ b/arch/arm/mach-omap1/mailbox.c
> @@ -160,7 +160,12 @@ static int __devinit omap1_mbox_probe(struct platform_device *pdev)
>  		dev_err(&pdev->dev, "invalid mem resource\n");
>  		return -ENODEV;
>  	}
> -	mbox_base = res->start;
> +
> +	mbox_base = ioremap(res->start, resource_size(res));
> +	if (!mbox_base) {
> +		dev_err(&pdev->dev, "ioremap failed\n");
> +		return -ENODEV;
> +	}
>  
>  	/* DSP IRQ */
>  	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);

This does not look right, if you look at mach-omap1/devices.c,
OMAP1_MBOX_BASE is still using OMAP1_IO_ADDRESS, so it's already
a virt address.

Maybe update the patch to remove OMAP1_IO_ADDRESS in
mach-omap1/devices.c?

Regards,

Tony