From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH] Restore task fs_root and pwd (v2) Date: Mon, 28 Dec 2009 20:58:46 -0600 Message-ID: <20091229025846.GA16492@us.ibm.com> References: <20091228183948.GA19788@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20091228183948.GA19788-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Oren Laadan Cc: Linux Containers List-Id: containers.vger.kernel.org Quoting Serge E. Hallyn (serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org): > Checkpoint and restore task->fs. Tasks sharing task->fs will > share them again after restart. Sigh. Shoulda written testcases in advance :) pwd restoration is fine. And technically root restoration is fine too. If any task which is not the container init did a chroot, the chroot is restored. However, the container init is chrooted (whether it was started using 'chroot app' or did a chroot() when it started up), then restart fails because the executable filename is relative to the chroot (i.e. /fssleep instead of /root/cr_tests/taskfs/tmp/fssleep), and isn't found. -serge