All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Len Brown <lenb@kernel.org>, Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-acpi@vger.kernel.org, Paul Rolland <rol@as2917.net>
Subject: [PATCH 1/2] dell-wmi - properly handle errors returned by wmi_install_notify_handler()
Date: Tue, 29 Dec 2009 00:34:14 -0800	[thread overview]
Message-ID: <20091229083226.13097.22110.stgit@localhost.localdomain> (raw)

wmi_install_notify_handler() retruns ACPI error codes instead of standard
Exxxx error codes and they should not be propagated unchanged to the upper
layers.

Reported-by: Paul Rolland <rol@as2917.net>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---

 drivers/platform/x86/dell-wmi.c |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index ff67a78..79bb1f1 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -265,6 +265,7 @@ static void __init find_hk_type(const struct dmi_header *dm, void *dummy)
 
 static int __init dell_wmi_init(void)
 {
+	acpi_status status;
 	int err;
 
 	if (!wmi_has_guid(DELL_EVENT_GUID)) {
@@ -279,12 +280,12 @@ static int __init dell_wmi_init(void)
 	if (err)
 		return err;
 
-	err = wmi_install_notify_handler(DELL_EVENT_GUID,
-					 dell_wmi_notify, NULL);
-	if (err) {
+	status = wmi_install_notify_handler(DELL_EVENT_GUID,
+					    dell_wmi_notify, NULL);
+	if (!ACPI_SUCCESS(status)) {
 		dell_wmi_input_destroy();
-		pr_err("Unable to register notify handler - %d\n", err);
-		return err;
+		pr_err("Unable to register notify handler - %d\n", status);
+		return -EIO;
 	}
 
 	return 0;


             reply	other threads:[~2009-12-29  8:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-29  8:34 Dmitry Torokhov [this message]
2009-12-29  8:34 ` [PATCH 2/2] hp-wmi - properly handle errors returned by wmi_install_notify_handler() Dmitry Torokhov
2009-12-29  8:56 ` [PATCH 1/2] dell-wmi " Dmitry Torokhov
2009-12-29  8:57 ` Paul Rolland
2009-12-29  9:21   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091229083226.13097.22110.stgit@localhost.localdomain \
    --to=dmitry.torokhov@gmail.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=rol@as2917.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.