All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Liming Wang <liming.wang@windriver.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Masami Hiramatsu <mhiramat@redhat.com>,
	Paul Mackerras <paulus@samba.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] perf tools: remove pid option from stat
Date: Wed, 30 Dec 2009 10:23:27 +0100	[thread overview]
Message-ID: <20091230092327.GA10486@elte.hu> (raw)
In-Reply-To: <1262088251.7135.131.camel@laptop>


* Peter Zijlstra <peterz@infradead.org> wrote:

> On Tue, 2009-12-29 at 16:37 +0800, Liming Wang wrote:
> > pid option is useless for stat, so remove it.
> 
> Hmm, it shouldn't be.. and instead of removing it I would suggesting fixing 
> this.

Yes. For exampe something like:

  perf stat --repeat 10 --pid $(pidof firefox) sleep 1

Should show firefox's resource usage sampled over 10 seconds.

If this doesnt work it should be fixed. Plus i suspect we should allow:

  perf stat --pid $(pidof firefox)

to run until Ctrl-C - like perf record allows.

	Ingo

  reply	other threads:[~2009-12-30  9:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-29  8:37 [PATCH 1/3] perf tools: unify event type description Liming Wang
2009-12-29  8:37 ` [PATCH 2/3] perf tools: remove pid option from stat Liming Wang
2009-12-29  8:37   ` [PATCH 3/3] perf probe: change CONFIG_KPROBE_TRACER to CONFIG_KPROBE_EVENT Liming Wang
2009-12-30  2:32     ` Masami Hiramatsu
2009-12-30 12:23     ` [tip:perf/core] perf probe: Change " tip-bot for Liming Wang
2009-12-29 12:04   ` [PATCH 2/3] perf tools: remove pid option from stat Peter Zijlstra
2009-12-30  9:23     ` Ingo Molnar [this message]
2009-12-30  9:29       ` Wang Liming
2009-12-31  8:05       ` [PATCH 1/1] perf tools: fix pid option for stat Liming Wang
2010-01-13 10:31         ` [tip:perf/core] perf tools: Fix --pid " tip-bot for Liming Wang
2009-12-30 12:22 ` [tip:perf/core] perf tools: Unify event type description tip-bot for Liming Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091230092327.GA10486@elte.hu \
    --to=mingo@elte.hu \
    --cc=fweisbec@gmail.com \
    --cc=liming.wang@windriver.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@redhat.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.