All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 1/2] perf: Pass appropriate frame pointer to dump_trace()
Date: Thu, 31 Dec 2009 07:13:54 +0100	[thread overview]
Message-ID: <20091231061352.GA5344@nowhere> (raw)
In-Reply-To: <1262235183-5320-1-git-send-regression-fweisbec@gmail.com>

On Thu, Dec 31, 2009 at 05:53:02AM +0100, Frederic Weisbecker wrote:
> Pass the frame pointer from the regs of the interrupted path
> to dump_trace() while processing the stack trace.
> 
> Currently, dump_trace() takes the current bp and starts the
> callchain from dump_trace() itself. This is wasteful because
> we need to walk through the entire NMI/DEBUG stack before
> retrieving the interrupted point.
> 
> We can fix that by just using the frame pointer from the captured
> regs. It points exactly where we want to start.



BTW, another effect of this patch: we didn't have the
nmi/debug stack frame filtering in x86-32. So the callchains
were polluted by the perf_callchain path, do_debug and so
on...

After this patch we don't need this filtering anymore
as the nmi/debug frames are zapped. It becomes clean
like in x86-64.


  parent reply	other threads:[~2009-12-31  6:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-31  4:53 [PATCH 1/2] perf: Pass appropriate frame pointer to dump_trace() Frederic Weisbecker
2009-12-31  4:53 ` [PATCH 2/2] perf: Drop useless check for ignored frame Frederic Weisbecker
2010-01-13 10:31   ` [tip:perf/core] " tip-bot for Frederic Weisbecker
2009-12-31  6:13 ` Frederic Weisbecker [this message]
2009-12-31 14:30 ` [tip:perf/urgent] perf: Pass appropriate frame pointer to dump_trace() tip-bot for Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091231061352.GA5344@nowhere \
    --to=fweisbec@gmail.com \
    --cc=acme@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.