From: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
To: Johannes Sixt <j6t@kdbg.org>
Cc: git@vger.kernel.org
Subject: Re: [Updated PATCH 2/2] Improve transport helper exec failure reporting
Date: Thu, 31 Dec 2009 18:59:04 +0200 [thread overview]
Message-ID: <20091231165904.GA24243@Knoppix> (raw)
In-Reply-To: <4B3CC6E5.7090404@kdbg.org>
On Thu, Dec 31, 2009 at 04:44:37PM +0100, Johannes Sixt wrote:
> Ilari Liusvaara schrieb:
> >@@ -31,13 +31,19 @@ static struct child_process *get_helper(struct transport *transport)
>
> You should set helper->silent_exec_failure = 1 when you give your
> own error message for the ENOENT case.
Ah yeah, might matter for Win32.
> BTW, which error message do you see without your change in this
> case? You only say "pretty much useless", but do not give an
> example.
git: 'remote-foo' is not a git-command. See 'git --help'.
And as first line of output, such thing is utterly confusing.
> >+ else
> >+ die("Unable to run helper %s: %s", helper->argv[0],
> >+ strerror(errno));
>
> You shouldn't write an error message here because start_command has
> already reported the error.
Its not printed on Unix.
-Ilari
next prev parent reply other threads:[~2009-12-31 16:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-30 10:52 [Updated PATCH 0/2] Improve remote helpers exec error reporting Ilari Liusvaara
2009-12-30 10:52 ` [Updated PATCH 1/2] Report exec errors from run-command Ilari Liusvaara
2009-12-30 13:47 ` Erik Faye-Lund
2009-12-31 5:26 ` Tarmigan
2009-12-31 10:48 ` Ilari Liusvaara
2009-12-31 14:44 ` Tarmigan
2009-12-30 10:52 ` [Updated PATCH 2/2] Improve transport helper exec failure reporting Ilari Liusvaara
2009-12-31 15:44 ` Johannes Sixt
2009-12-31 16:59 ` Ilari Liusvaara [this message]
2009-12-31 17:48 ` Johannes Sixt
2009-12-31 18:24 ` Ilari Liusvaara
2009-12-31 18:44 ` Johannes Sixt
2010-01-01 0:34 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091231165904.GA24243@Knoppix \
--to=ilari.liusvaara@elisanet.fi \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.