All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] 40TB RAID and OCFS2 woes (inode64, JDB2, huge partition support, Volume might try to write to blocks beyond what jbd can address in 32 bits)
Date: Thu, 31 Dec 2009 12:08:36 -0800	[thread overview]
Message-ID: <20091231200836.GA3301@mail.oracle.com> (raw)
In-Reply-To: <6575F4FA-312C-4CB4-AA92-6AF7ECEF3EEA@wansecurity.com>

On Fri, Jan 01, 2010 at 04:36:02AM +0900, Robert Smith wrote:
> Oh, I found it at line #2163 of fs/ocfs2/super.c.
> 
> I imagine that something as simple as the following would work, but perhaps I'll wait for your feedback.
> 
> 
> /*
>         if (ocfs2_clusters_to_blocks(osb->sb, le32_to_cpu(di->i_clusters) - 1)
>             > (u32)~0UL) {
>                 mlog(ML_ERROR, "Volume might try to write to blocks beyond "
>                      "what jbd can address in 32 bits.\n");
>                 status = -EINVAL;
>                 goto bail;
>         }
> */

	That should work.  The real solution will check based on the
journal flags.  Be warned, there be tygers in here.

Joel

-- 

"But all my words come back to me
 In shades of mediocrity.
 Like emptiness in harmony
 I need someone to comfort me."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127

  reply	other threads:[~2009-12-31 20:08 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-30 14:30 [Ocfs2-devel] 40TB RAID and OCFS2 woes (inode64, JDB2, huge partition support, Volume might try to write to blocks beyond what jbd can address in 32 bits) Robert Smith
2009-12-30 20:34 ` Joel Becker
2009-12-30 22:25   ` Robert Smith
2009-12-30 22:49     ` Sunil Mushran
2009-12-31  3:42     ` Joel Becker
2009-12-31 18:15       ` Robert Smith
2009-12-31 19:05         ` Sunil Mushran
2009-12-31 19:20           ` Robert Smith
2009-12-31 19:36           ` Robert Smith
2009-12-31 20:08             ` Joel Becker [this message]
2010-01-01  6:12               ` [Ocfs2-devel] 40TB RAID and OCFS2 woes (inode64, JBD2, " Robert Smith
2010-01-02 20:15                 ` Joel Becker
2010-01-01 19:47               ` [Ocfs2-devel] 40TB RAID and OCFS2 woes (inode64, JDB2, " Robert Smith
2010-01-02  7:33                 ` Tao Ma
2010-01-04  1:09                   ` Robert Smith
2010-01-04  2:36                     ` Tao Ma
2010-01-05 19:28                       ` Robert Smith
2010-01-02 20:19                 ` Joel Becker
2010-01-04  1:20                   ` Robert Smith
2009-12-31  8:19     ` Tao Ma
2009-12-31 17:42       ` Robert Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091231200836.GA3301@mail.oracle.com \
    --to=joel.becker@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.